April 2020 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: lspcon_i2c_spi.c: Clean up some unnecessary indirection
by Edward O'Callaghan (Code Review) 19 Apr '20

19 Apr '20

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40470 ) Change subject: lspcon_i2c_spi.c: Clean up some unnecessary indirection ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > Needs a rebase To re-trigger the buildbot? Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/40470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66ba4ffeb696309b8ad5b5ba58650630e8feefa9 Gerrit-Change-Number: 40470 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 19 Apr 2020 05:25:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: lspcon_i2c_spi.c: Clean up some unnecessary indirection
by Angel Pons (Code Review) 18 Apr '20

18 Apr '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40470 ) Change subject: lspcon_i2c_spi.c: Clean up some unnecessary indirection ...................................................................... Patch Set 1: Code-Review+1 Needs a rebase -- To view, visit https://review.coreboot.org/c/flashrom/+/40470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66ba4ffeb696309b8ad5b5ba58650630e8feefa9 Gerrit-Change-Number: 40470 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Shiyu Sun <sshiyu(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Apr 2020 19:19:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Disable SPI on ICH7 if booted from LPC
by Angel Pons (Code Review) 15 Apr '20

15 Apr '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40401 ) Change subject: chipset_enable.c: Disable SPI on ICH7 if booted from LPC ...................................................................... chipset_enable.c: Disable SPI on ICH7 if booted from LPC Commit 92d6a86 ("Refactor Intel Chipset Enables") eliminated a check to disable SPI when ICH7 has booted from LPC, as the hardware does not support it. Therefore, when flashrom probes the SPI bus, it times out waiting for the hardware to react, for each and every SPI flash chip. This results in very long delays and countless instances of the error: Error: SCIP never cleared! To prevent this, bring back part of the lost check. Probing for LPC and FWH when booted from SPI does not seem to cause any problems on desktop mainboards with ICH7, so don't disable LPC nor FWH if that is the case. UNTESTED. Change-Id: I5e59e66a2dd16b07f2dca410997fce38ab9c8fd1 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M chipset_enable.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/40401/1 diff --git a/chipset_enable.c b/chipset_enable.c index 36d0dbe..783bb94 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -757,6 +757,14 @@ if (ret_fwh == ERROR_FATAL) return ret_fwh; + /* + * It seems that the ICH7 does not support SPI and LPC chips at the same time. When booted + * from LPC, the SCIP bit will never clear, which causes long delays and many error messages. + * To avoid this, we will not enable SPI on ICH7 when the southbridge is strapped to LPC. + */ + if (ich_generation == CHIPSET_ICH7 && (boot_buses & BUS_LPC)) + return 0; + /* SPIBAR is at RCRB+0x3020 for ICH[78], Tunnel Creek and Centerton, and RCRB+0x3800 for ICH9. */ uint16_t spibar_offset; switch (ich_generation) { -- To view, visit https://review.coreboot.org/c/flashrom/+/40401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5e59e66a2dd16b07f2dca410997fce38ab9c8fd1 Gerrit-Change-Number: 40401 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

2 7

Change in flashrom[master]: Hide redondant 'Error: SCIP never cleared!' message
by HAOUAS Elyes (Code Review) 15 Apr '20

15 Apr '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40328 ) Change subject: Hide redondant 'Error: SCIP never cleared!' message ...................................................................... Hide redondant 'Error: SCIP never cleared!' message This will hide redondant 'Error: SCIP never cleared!' messahe on ICH7. https://paste.flashrom.org/view.php?id=3282 Note that this will take a very long time in comparison with v0.9.7-r1711 version. current version gives: time ./flashrom -p internal flashrom v1.2-24-gf572b50-dirty on Linux 5.4.0-4-amd64 (x86_64) flashrom is free software, get the source code at https://flashrom.org Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Found chipset "Intel ICH7/ICH7R". Enabling flash write... OK. Found SST flash chip "SST49LF004A/B" (512 kB, FWH) mapped at physical address 0x00000000fff80000. No operations were specified. real 0m31,031s user 0m10,079s sys 0m20,785s and old version v0.9.7-r171 will go faster: time ./flashrom -p internal flashrom v0.9.7-r1711 on Linux 5.4.0-4-amd64 (x86_64) flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. sh: 1: dmidecode: not found dmidecode execution unsuccessful - continuing without DMI info Found chipset "Intel ICH7/ICH7R". Enabling flash write... OK. Found SST flash chip "SST49LF004A/B" (512 kB, FWH) at physical address 0xfff80000. No operations were specified. real 0m0,861s user 0m0,844s sys 0m0,008s Change-Id: I0795653bd9ababccf666ed8af0c9bff22853371d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M ichspi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/28/40328/1 diff --git a/ichspi.c b/ichspi.c index 12ee126..19fc29e 100644 --- a/ichspi.c +++ b/ichspi.c @@ -852,7 +852,7 @@ programmer_delay(10); } if (!timeout) { - msg_perr("Error: SCIP never cleared!\n"); + msg_pdbg("Error: SCIP never cleared!\n"); return 1; } -- To view, visit https://review.coreboot.org/c/flashrom/+/40328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0795653bd9ababccf666ed8af0c9bff22853371d Gerrit-Change-Number: 40328 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 6

Change in flashrom[master]: cli_classic.c: Prevent memory leak
by Angel Pons (Code Review) 14 Apr '20

14 Apr '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/39972 ) Change subject: cli_classic.c: Prevent memory leak ...................................................................... cli_classic.c: Prevent memory leak If the `--flash-contents` switch is specified more than once, it will result in a memory leak. Therefore, allow this option only once. Change-Id: I530933c9a6431580fe4645396bb363939472a80a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M cli_classic.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/39972/1 diff --git a/cli_classic.c b/cli_classic.c index 73cc417..967ff50 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -273,6 +273,9 @@ } break; case OPTION_FLASH_CONTENTS: + if (referencefile) + cli_classic_abort_usage("Error: --flash-contents specified more than once." + "Aborting.\n"); referencefile = strdup(optarg); break; case OPTION_FLASH_NAME: -- To view, visit https://review.coreboot.org/c/flashrom/+/39972 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I530933c9a6431580fe4645396bb363939472a80a Gerrit-Change-Number: 39972 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

2 2

Change in flashrom[master]: flashchips: Add support for Winbond W25Q64JW
by Hung-Te Lin (Code Review) 13 Apr '20

13 Apr '20

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: flashchips: Add support for Winbond W25Q64JW ...................................................................... Patch Set 10: > Will this CL be updated to chromium gerrit? It's not done automatically. Please rebase your change in chromium and add the link to here in its description comment (and make it clear this is from upstream) and get review again. -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 10 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 13 Apr 2020 07:48:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for Winbond W25Q64JW
by Scott Chao (Code Review) 13 Apr '20

13 Apr '20

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: flashchips: Add support for Winbond W25Q64JW ...................................................................... Patch Set 10: Will this CL be updated to chromium gerrit? -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 10 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 13 Apr 2020 07:16:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Copy Verified label from coreboot
by Nico Huber (Code Review) 09 Apr '20

09 Apr '20

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/39640 ) Change subject: Copy Verified label from coreboot ...................................................................... Copy Verified label from coreboot Change-Id: Ie77d5b461992c166c54d01ecda6fb509ad0a4407 Reviewed-on: https://review.coreboot.org/c/flashrom/+/39640 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Tested-by: Nico Huber <nico.h(a)gmx.de> --- M project.config 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Nico Huber: Verified; Looks good to me, but someone else must approve David Hendricks: Looks good to me, approved diff --git a/project.config b/project.config index e3b7a6d..e1e963e 100644 --- a/project.config +++ b/project.config @@ -9,6 +9,15 @@ createTag = group flashrom developers createSignedTag = group flashrom developers +[label "Verified"] + function = MaxWithBlock + value = -1 Fails + value = 0 No score + value = +1 Verified + copyAllScoresOnTrivialRebase = true + copyAllScoresIfNoCodeChange = true + defaultValue = 0 + [label "Code-Review"] function = MaxWithBlock abbreviation = R -- To view, visit https://review.coreboot.org/c/flashrom/+/39640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Ie77d5b461992c166c54d01ecda6fb509ad0a4407 Gerrit-Change-Number: 39640 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-MessageType: merged

1 0

Change in flashrom[refs/meta/config]: Copy Verified label from coreboot
by Nico Huber (Code Review) 09 Apr '20

09 Apr '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39640 ) Change subject: Copy Verified label from coreboot ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/39640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Ie77d5b461992c166c54d01ecda6fb509ad0a4407 Gerrit-Change-Number: 39640 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Thu, 09 Apr 2020 15:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for Winbond W25Q64JW
by Edward O'Callaghan (Code Review) 09 Apr '20

09 Apr '20

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: flashchips: Add support for Winbond W25Q64JW ...................................................................... flashchips: Add support for Winbond W25Q64JW BUG=b:153515968 BRANCH=kukui TEST=flash coreboot on kakadu and get successful result. Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/40275 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Hung-Te Lin <hungte(a)chromium.org> Tested-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M flashchips.c M flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: Edward O'Callaghan: Verified; Looks good to me, approved Angel Pons: Looks good to me, approved Hung-Te Lin: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 64fdbb9..b4006df 100644 --- a/flashchips.c +++ b/flashchips.c @@ -17130,6 +17130,46 @@ { .vendor = "Winbond", + .name = "W25Q64JW", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q64JW, + .total_size = 8192, + .page_size = 256, + /* OTP: 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* QPI enable 0x38, disable 0xFF */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 2048} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 256} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 128} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {8 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1700, 1950}, /* Fast read (0x0B) and multi I/O supported */ + }, + + { + .vendor = "Winbond", .name = "W25Q80.V", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/flashchips.h b/flashchips.h index 29294fb..e5ef390 100644 --- a/flashchips.h +++ b/flashchips.h @@ -943,6 +943,7 @@ #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ #define WINBOND_NEX_W25Q256JV_M 0x7019 /* W25Q256JV_M (QE=0) */ +#define WINBOND_NEX_W25Q64JW 0x8017 #define WINBOND_NEX_W25Q128_DTR 0x8018 /* W25Q128JW_DTR */ #define WINBOND_ID 0xDA /* Winbond */ -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 10 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2020