April 2020 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: support for Winbond W25Q64JW
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Edward O'Callaghan, Angel Pons, Peichao Li, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/40275 to look at the new patch set (#6). Change subject: flashchips: support for Winbond W25Q64JW ...................................................................... flashchips: support for Winbond W25Q64JW BUG=b:153515968 BRANCH=kukui TEST=flash coreboot on kakadu and get successful result. Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> --- M flashchips.c M flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/40275/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 6 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: support Winbond W25Q64JW
by Angel Pons (Code Review) 09 Apr '20

09 Apr '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: flashchips: support Winbond W25Q64JW ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Looks good, thank you! One small nit in the commit message, though. Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner). https://review.coreboot.org/c/flashrom/+/40275/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/40275/5//COMMIT_MSG@7 PS5, Line 7: support Add support for -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 09 Apr 2020 13:30:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: support Winbond W25Q64JW
by Hung-Te Lin (Code Review) 09 Apr '20

09 Apr '20

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: flashchips: support Winbond W25Q64JW ...................................................................... Patch Set 5: Thanks. No concern for now. -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-Comment-Date: Thu, 09 Apr 2020 05:49:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: support Winbond W25Q64JW
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: flashchips: support Winbond W25Q64JW ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/flashrom/+/40275/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/40275/4//COMMIT_MSG@7 PS4, Line 7: spi: add support for Winbond W25Q64JW > oh one more thing. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-Comment-Date: Thu, 09 Apr 2020 05:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: support Winbond W25Q64JW
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Edward O'Callaghan, Peichao Li, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/40275 to look at the new patch set (#5). Change subject: flashchips: support Winbond W25Q64JW ...................................................................... flashchips: support Winbond W25Q64JW BUG=b:153515968 BRANCH=kukui TEST=flash coreboot on kakadu and get successful result. Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> --- M flashchips.c M flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/40275/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: spi: add support for Winbond W25Q64JW
by Hung-Te Lin (Code Review) 09 Apr '20

09 Apr '20

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: spi: add support for Winbond W25Q64JW ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/flashrom/+/40275/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/40275/4//COMMIT_MSG@7 PS4, Line 7: spi: add support for Winbond W25Q64JW oh one more thing. You probably have copied this from firmware patches, but it's apparently not 'spi' here. flashchips: support Winbond W25Q64JW -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-Comment-Date: Thu, 09 Apr 2020 05:39:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi: add support for Winbond W25Q64JW
by Hung-Te Lin (Code Review) 09 Apr '20

09 Apr '20

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: spi: add support for Winbond W25Q64JW ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-Comment-Date: Thu, 09 Apr 2020 05:38:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi: add support for Winbond W25Q64JW
by Edward O'Callaghan (Code Review) 09 Apr '20

09 Apr '20

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: spi: add support for Winbond W25Q64JW ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-Comment-Date: Thu, 09 Apr 2020 04:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi: add support for Winbond W25Q64JW
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 ) Change subject: spi: add support for Winbond W25Q64JW ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/flashrom/+/40275/3/flashchips.c File flashchips.c: https://review.coreboot.org/c/flashrom/+/40275/3/flashchips.c@17133 PS3, Line 17133: ZPIM > I think you can't tell if this is ZPIM or SSIG from model id; so maybe just leave it as W25Q64JW? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-Comment-Date: Thu, 09 Apr 2020 04:26:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi: add support for Winbond W25Q64JW
by Scott Chao (Code Review) 09 Apr '20

09 Apr '20

Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Edward O'Callaghan, Peichao Li, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/40275 to look at the new patch set (#4). Change subject: spi: add support for Winbond W25Q64JW ...................................................................... spi: add support for Winbond W25Q64JW BUG=b:153515968 BRANCH=kukui TEST=flash coreboot on kakadu and get successful result. Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> --- M flashchips.c M flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/40275/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/40275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967 Gerrit-Change-Number: 40275 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com> Gerrit-CC: Paul Ma <magf(a)bitland.com.cn> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2020