Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: Add support for Winbond W25Q64JW
......................................................................
Patch Set 9: Verified+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 9
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 14:58:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: Add support for Winbond W25Q64JW
......................................................................
Patch Set 9: Code-Review+2
Thank you! Now, if you could rebase on something else, then on master again, and I'll submit this. Sorry for the inconvenience :S
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 9
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 14:57:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: Add support for Winbond W25Q64JW
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40275/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/40275/8//COMMIT_MSG@7
PS8, Line 7: support
> Um, this is still the same though :S
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 9
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 14:41:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Hello Hung-Te Lin, build bot (Jenkins), Martin Roth, Patrick Georgi, Edward O'Callaghan, Angel Pons, Peichao Li, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/40275
to look at the new patch set (#9).
Change subject: flashchips: Add support for Winbond W25Q64JW
......................................................................
flashchips: Add support for Winbond W25Q64JW
BUG=b:153515968
BRANCH=kukui
TEST=flash coreboot on kakadu and get successful result.
Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Signed-off-by: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
---
M flashchips.c
M flashchips.h
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/40275/9
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 9
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39640 )
Change subject: Copy Verified label from coreboot
......................................................................
Patch Set 3:
Any updates?
--
To view, visit https://review.coreboot.org/c/flashrom/+/39640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: refs/meta/config
Gerrit-Change-Id: Ie77d5b461992c166c54d01ecda6fb509ad0a4407
Gerrit-Change-Number: 39640
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Stefan T <stefan.tauner(a)gmx.at>
Gerrit-Comment-Date: Thu, 09 Apr 2020 14:40:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW
......................................................................
Patch Set 8:
(1 comment)
> Patch Set 8:
>
> > Patch Set 8:
> >
> > > Patch Set 5: Code-Review+1
> > >
> > > (1 comment)
> > >
> > > Looks good, thank you! One small nit in the commit message, though.
> > >
> > > Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner).
> >
> > When I triggered a rebase, it showed "Could not perform action: Change is already up to date.". Is that correct?
>
> That's fine, I fixed the missing Verified.
I'd still prefer to have Jenkins build-test it, just in case. BTW, this would not be an issue with CB:39640
https://review.coreboot.org/c/flashrom/+/40275/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/40275/8//COMMIT_MSG@7
PS8, Line 7: support
Um, this is still the same though :S
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 8
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 14:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW
......................................................................
Patch Set 8:
> Patch Set 8:
>
> > Patch Set 5: Code-Review+1
> >
> > (1 comment)
> >
> > Looks good, thank you! One small nit in the commit message, though.
> >
> > Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner).
>
> When I triggered a rebase, it showed "Could not perform action: Change is already up to date.". Is that correct?
That's fine, I fixed the missing Verified.
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 8
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 14:02:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW
......................................................................
Patch Set 8:
> Patch Set 5: Code-Review+1
>
> (1 comment)
>
> Looks good, thank you! One small nit in the commit message, though.
>
> Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner).
When I triggered a rebase, it showed "Could not perform action: Change is already up to date.". Is that correct?
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 8
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 13:51:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW
......................................................................
Patch Set 6: Verified+1
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 6
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 13:46:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40275/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/40275/5//COMMIT_MSG@7
PS5, Line 7: support
> Add support for
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 6
Gerrit-Owner: Scott Chao <scott.chao(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper.chang(a)bitland.corp-partner.google.com>
Gerrit-CC: Paul Ma <magf(a)bitland.com.cn>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 09 Apr 2020 13:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment