Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48949 )
Change subject: flashchips.c: Add support for XMC new spi flash types
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/48949/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/48949/3//COMMIT_MSG@16
PS3, Line 16: TEST=test
Was a test actually performed?
e.g.,
`TEST=flash image, then read it back then erased successfully.`
Also no need to indent the commit message. For an example of a commit message format see https://review.coreboot.org/c/flashrom/+/44073https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.h
File flashchips.h:
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.h@814
PS1, Line 814:
> two tabs needed to line up with the rest from the looks of it.
Click "Resolve" on comments that were fixed.
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19004
PS1, Line 19004: TEST_OK_PREW
> Were these all tested? if not then you want `TEST_UNTESTED`. […]
I feel like the `TEST=` line should indicate these were not actually tested from the sounds of things. So in the commit message `TEST=builds` and for each chip `.tested = TEST_UNTESTED`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/48949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
Gerrit-Change-Number: 48949
Gerrit-PatchSet: 3
Gerrit-Owner: luke <sixuerain(a)qq.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Wed, 30 Dec 2020 11:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Carl-Daniel Hailfinger, Uwe Hermann,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/48949
to look at the new patch set (#3).
Change subject: flashchips.c: Add support for XMC new spi flash types
......................................................................
flashchips.c: Add support for XMC new spi flash types
XM25QU64C
XM25QU128C
XM25QU256C
XM25QH64C
XM25QH128C
XM25QH256C
TEST=test
Signed-off-by: Luke He <sixuerain(a)qq.com>
Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
---
M flashchips.c
M flashchips.h
2 files changed, 245 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/48949/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/48949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
Gerrit-Change-Number: 48949
Gerrit-PatchSet: 3
Gerrit-Owner: luke <sixuerain(a)qq.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Carl-Daniel Hailfinger, Uwe Hermann,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/48949
to look at the new patch set (#2).
Change subject: flashchips.c: Add support for XMC new spi flash types
......................................................................
flashchips.c: Add support for XMC new spi flash types
XM25QU64C
XM25QU128C
XM25QU256C
XM25QH64C
XM25QH128C
XM25QH256C
Signed-off-by: Luke He <sixuerain(a)qq.com>
Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
---
M flashchips.c
M flashchips.h
2 files changed, 245 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/49/48949/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/48949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
Gerrit-Change-Number: 48949
Gerrit-PatchSet: 2
Gerrit-Owner: luke <sixuerain(a)qq.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Luke He has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48949 )
Change subject: flashchips.c: Add support for XMC new spi flash types
......................................................................
Patch Set 1:
this patch is for XMC new spi flash
--
To view, visit https://review.coreboot.org/c/flashrom/+/48949
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
Gerrit-Change-Number: 48949
Gerrit-PatchSet: 1
Gerrit-Owner: Luke He <sixuerain(a)qq.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger(a)gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de>
Gerrit-Comment-Date: Mon, 28 Dec 2020 12:14:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment