Shiyu Sun has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46870 )
Change subject: Makefile: remove LSPCON and MST device dependency from libusb
......................................................................
Makefile: remove LSPCON and MST device dependency from libusb
LSPCON and MST does not depends on libusb.
Signed-off-by: Shiyu Sun <sshiyu(a)chromium.org>
Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e
---
M Makefile
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/46870/1
diff --git a/Makefile b/Makefile
index 241814a..4a78287 100644
--- a/Makefile
+++ b/Makefile
@@ -812,8 +812,6 @@
override CONFIG_PICKIT2_SPI = no
override CONFIG_RAIDEN = no
override CONFIG_STLINKV3_SPI = no
-override CONFIG_LSPCON_I2C_SPI = no
-override CONFIG_REALTEK_MST_I2C_SPI = no
endif
ifeq ($(CONFIG_ENABLE_LIBPCI_PROGRAMMERS), no)
override CONFIG_INTERNAL = no
--
To view, visit https://review.coreboot.org/c/flashrom/+/46870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e
Gerrit-Change-Number: 46870
Gerrit-PatchSet: 1
Gerrit-Owner: Shiyu Sun <sshiyu(a)google.com>
Gerrit-MessageType: newchange
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46524 )
Change subject: dummyflasher.c: Do not print an error if probing fails
......................................................................
dummyflasher.c: Do not print an error if probing fails
This line gets printed even when not using dummyflasher at all. Drop it.
TEST=Check that no spurious error message appears with ft2232_spi.
Change-Id: I1a81a735db391357d1b6ee6f3e9844255efd0e19
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M dummyflasher.c
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/46524/1
diff --git a/dummyflasher.c b/dummyflasher.c
index d233db4..afcbeb6 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -1029,13 +1029,9 @@
{
unsigned int i;
const struct emu_data *emu_data = get_data_from_context(flash);
- if (!emu_data) {
- msg_perr("No data in flash context!\n");
- return 0;
- }
/* Skip the probing if we don't emulate this chip. */
- if (emu_data->emu_chip != EMULATE_VARIABLE_SIZE)
+ if (!emu_data || emu_data->emu_chip != EMULATE_VARIABLE_SIZE)
return 0;
/*
--
To view, visit https://review.coreboot.org/c/flashrom/+/46524
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1a81a735db391357d1b6ee6f3e9844255efd0e19
Gerrit-Change-Number: 46524
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46444 )
Change subject: chipset_enable.c: check return value from rphysmap() call
......................................................................
chipset_enable.c: check return value from rphysmap() call
Port from the ChromiumOS fork of flashrom.
Change-Id: I8075fe5f80ac0da5280d2f0de6829ed3a2496476
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M chipset_enable.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/46444/1
diff --git a/chipset_enable.c b/chipset_enable.c
index 9769ba4..4273478 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -1010,6 +1010,8 @@
uint32_t sbase = pci_read_long(dev, 0x54) & 0xfffffe00;
msg_pdbg("SPI_BASE_ADDRESS = 0x%x\n", sbase);
void *spibar = rphysmap("BYT SBASE", sbase, 512); /* Last defined address on Bay Trail is 0x100 */
+ if (spibar == ERROR_PTR)
+ return ERROR_FATAL;
/* Enable Flash Writes.
* Silvermont-based: BCR at SBASE + 0xFC (some bits of BCR are also accessible via BC at IBASE + 0x1C).
--
To view, visit https://review.coreboot.org/c/flashrom/+/46444
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8075fe5f80ac0da5280d2f0de6829ed3a2496476
Gerrit-Change-Number: 46444
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46811 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS
......................................................................
Mark ENE_LPC and MEC1308 as NEED_RAW_ACCESS
Both uses INB/OUTB and hence should be marked as NEED_RAW_ACCESS in the
makefiles; fixing.
Signed-off-by: Victor Ding <victording(a)google.com>
Change-Id: I6fafd9f59d06f60e9491e3e059c1205d48d8232e
---
M Makefile
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/46811/1
diff --git a/Makefile b/Makefile
index 8af7042..3a0748c 100644
--- a/Makefile
+++ b/Makefile
@@ -898,11 +898,13 @@
ifeq ($(CONFIG_ENE_LPC), yes)
FEATURE_CFLAGS += -D'CONFIG_ENE_LPC=1'
PROGRAMMER_OBJS += ene_lpc.o
+NEED_RAW_ACCESS += CONFIG_ENE_LPC
endif
ifeq ($(CONFIG_MEC1308), yes)
FEATURE_CFLAGS += -D'CONFIG_MEC1308=1'
PROGRAMMER_OBJS += mec1308.o
+NEED_RAW_ACCESS += CONFIG_MEC1308
endif
ifeq ($(CONFIG_SERPROG), yes)
--
To view, visit https://review.coreboot.org/c/flashrom/+/46811
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6fafd9f59d06f60e9491e3e059c1205d48d8232e
Gerrit-Change-Number: 46811
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-MessageType: newchange
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46546 )
Change subject: flashrom.c,flash.h: Kill dead fn shutdown_free()
......................................................................
flashrom.c,flash.h: Kill dead fn shutdown_free()
Seems to be dead code with no call sites.
BUG=none
BRANCH=none
TEST=builds
Change-Id: Ic9f33415b8a357916891cb2006612cbf5e6aa559
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M flash.h
M flashrom.c
2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/46546/1
diff --git a/flash.h b/flash.h
index fefca9d..203d32d 100644
--- a/flash.h
+++ b/flash.h
@@ -54,7 +54,6 @@
#define PRIxPTR_WIDTH ((int)(sizeof(uintptr_t)*2))
int register_shutdown(int (*function) (void *data), void *data);
-int shutdown_free(void *data);
void *programmer_map_flash_region(const char *descr, uintptr_t phys_addr, size_t len);
void programmer_unmap_flash_region(void *virt_addr, size_t len);
void programmer_delay(unsigned int usecs);
diff --git a/flashrom.c b/flashrom.c
index c18a04f..26e2df8 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -553,12 +553,6 @@
static int check_block_eraser(const struct flashctx *flash, int k, int log);
-int shutdown_free(void *data)
-{
- free(data);
- return 0;
-}
-
/* Register a function to be executed on programmer shutdown.
* The advantage over atexit() is that you can supply a void pointer which will
* be used as parameter to the registered function upon programmer shutdown.
--
To view, visit https://review.coreboot.org/c/flashrom/+/46546
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic9f33415b8a357916891cb2006612cbf5e6aa559
Gerrit-Change-Number: 46546
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange