Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46869 )
Change subject: Makefile: Fix typo NEED_LIBUSB0 -> NEED_LIBUSB1 ......................................................................
Makefile: Fix typo NEED_LIBUSB0 -> NEED_LIBUSB1
BUG=none BRANCH=none TEST=none
Change-Id: I5a402d9530f73419d8317d94a8d6f745d09675ea Signed-off-by: Edward O'Callaghan quasisec@google.com --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/46869/1
diff --git a/Makefile b/Makefile index 241814a..d2b1637 100644 --- a/Makefile +++ b/Makefile @@ -1024,7 +1024,7 @@ FTDI_INCLUDES := $(call debug_shell,[ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ; $(PKG_CONFIG) --cflags-only-I libftdi1) FEATURE_CFLAGS += $(FTDI_INCLUDES) FEATURE_LIBS += $(call debug_shell,grep -q "FTDISUPPORT := yes" .features && printf "%s" "$(FTDILIBS)") -# We can't set NEED_LIBUSB0 here because that would transform libftdi auto-enabling +# We can't set NEED_LIBUSB1 here because that would transform libftdi auto-enabling # into a hard requirement for libusb, defeating the purpose of auto-enabling. endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46869 )
Change subject: Makefile: Fix typo NEED_LIBUSB0 -> NEED_LIBUSB1 ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46869 )
Change subject: Makefile: Fix typo NEED_LIBUSB0 -> NEED_LIBUSB1 ......................................................................
Makefile: Fix typo NEED_LIBUSB0 -> NEED_LIBUSB1
BUG=none BRANCH=none TEST=none
Change-Id: I5a402d9530f73419d8317d94a8d6f745d09675ea Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/46869 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index 4a78287..225db9d 100644 --- a/Makefile +++ b/Makefile @@ -1022,7 +1022,7 @@ FTDI_INCLUDES := $(call debug_shell,[ -n "$(PKG_CONFIG_LIBDIR)" ] && export PKG_CONFIG_LIBDIR="$(PKG_CONFIG_LIBDIR)" ; $(PKG_CONFIG) --cflags-only-I libftdi1) FEATURE_CFLAGS += $(FTDI_INCLUDES) FEATURE_LIBS += $(call debug_shell,grep -q "FTDISUPPORT := yes" .features && printf "%s" "$(FTDILIBS)") -# We can't set NEED_LIBUSB0 here because that would transform libftdi auto-enabling +# We can't set NEED_LIBUSB1 here because that would transform libftdi auto-enabling # into a hard requirement for libusb, defeating the purpose of auto-enabling. endif
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)