Change in flashrom[master]: Makefile: remove LSPCON and MST device dependency from libusb

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

Shiyu Sun (Code Review)

28 Oct 2020 28 Oct '20

6:14 a.m.

Shiyu Sun has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Makefile: remove LSPCON and MST device dependency from libusb

LSPCON and MST does not depends on libusb.

Signed-off-by: Shiyu Sun sshiyu@chromium.org Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e --- M Makefile 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/46870/1

diff --git a/Makefile b/Makefile index 241814a..4a78287 100644 --- a/Makefile +++ b/Makefile @@ -812,8 +812,6 @@ override CONFIG_PICKIT2_SPI = no override CONFIG_RAIDEN = no override CONFIG_STLINKV3_SPI = no -override CONFIG_LSPCON_I2C_SPI = no -override CONFIG_REALTEK_MST_I2C_SPI = no endif ifeq ($(CONFIG_ENABLE_LIBPCI_PROGRAMMERS), no) override CONFIG_INTERNAL = no

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Edward O'Callaghan (Code Review)

28 Oct 28 Oct

6:32 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/46870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Gerrit-Change-Number: 46870 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Oct 2020 05:32:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

8:33 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG@9 PS1, Line 9: does nit: do

-- To view, visit https://review.coreboot.org/c/flashrom/+/46870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Gerrit-Change-Number: 46870 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 28 Oct 2020 07:33:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10:05 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG@9 PS1, Line 9: depends nit: depend

-- To view, visit https://review.coreboot.org/c/flashrom/+/46870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Gerrit-Change-Number: 46870 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 28 Oct 2020 09:05:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11:16 a.m.

Patrick Georgi has uploaded a new patch set (#2) to the change originally created by Shiyu Sun. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Makefile: remove LSPCON and MST device dependency from libusb

LSPCON and MST do not depend on libusb.

Signed-off-by: Shiyu Sun sshiyu@chromium.org Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e --- M Makefile 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/46870/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/46870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Gerrit-Change-Number: 46870 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

11:16 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG@9 PS1, Line 9: depends

...

nit: depend

Done

https://review.coreboot.org/c/flashrom/+/46870/1//COMMIT_MSG@9 PS1, Line 9: does

...

nit: do

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/46870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Gerrit-Change-Number: 46870 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 28 Oct 2020 10:16:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11:17 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46870 )

Change subject: Makefile: remove LSPCON and MST device dependency from libusb ......................................................................

Makefile: remove LSPCON and MST device dependency from libusb

LSPCON and MST do not depend on libusb.

Signed-off-by: Shiyu Sun sshiyu@chromium.org Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Reviewed-on: https://review.coreboot.org/c/flashrom/+/46870 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Makefile 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/flashrom/+/46870 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6db3a318aca349fc1ccd343d3d6d47b809eac8e Gerrit-Change-Number: 46870 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1275

days inactive

1275

days old

flashrom-gerrit@flashrom.org

6 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Edward O'Callaghan (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Shiyu Sun (Code Review)