May 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Add a generic 27C256 definition (32k UV EPROM)
by Urja Rannikko (Code Review) 07 May '17

07 May '17

Urja Rannikko has uploaded a new change for review. ( https://review.coreboot.org/19616 ) Change subject: Add a generic 27C256 definition (32k UV EPROM) ...................................................................... Add a generic 27C256 definition (32k UV EPROM) This is so that they're readable and verifiable with -c 27C256, and that it is possible to read a correctly sized image from them. Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> Change-Id: Ie726ff252bc398d78e76bfb5ed01359341b734f3 --- M flashchips.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/19616/1 diff --git a/flashchips.c b/flashchips.c index 40b6b8e..90c607f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15879,7 +15879,20 @@ .read = read_memmapped, .voltage = {3000, 3600}, /* Also has 12V fast program */ }, - + + { + .vendor = "Generic", /* "Unknown" gets filtered from -L. */ + .name = "27C256", + .bustype = BUS_PARALLEL, + .total_size = 32, + .page_size = 32 * 1024, + .tested = { .probe = NA, .read = OK, .erase = NA, .write = BAD }, + .probe = probe_dummy, + .write = NULL, + .read = read_memmapped, + .voltage = {4500, 5500}, + }, + { .vendor = "Unknown", .name = "SFDP-capable chip", -- To view, visit https://review.coreboot.org/19616 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie726ff252bc398d78e76bfb5ed01359341b734f3 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>

1 0

Change in flashrom[staging]: Add probe_dummy for chips that are not practical to probe
by Urja Rannikko (Code Review) 07 May '17

07 May '17

Urja Rannikko has uploaded a new change for review. ( https://review.coreboot.org/19615 ) Change subject: Add probe_dummy for chips that are not practical to probe ...................................................................... Add probe_dummy for chips that are not practical to probe This is in preparation for read-only definition of a 27C256. Change-Id: I327400e337d6ce600c4f0f165f328715f5b341e2 Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M chipdrivers.h M flashrom.c 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/15/19615/1 diff --git a/chipdrivers.h b/chipdrivers.h index c85eac9..eeb9d27 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -27,6 +27,9 @@ #include "flash.h" /* for chipaddr and flashctx */ +/* flashrom.c */ +int probe_dummy(struct flashctx *flash); + /* spi.c */ int spi_aai_write(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int spi_chip_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); diff --git a/flashrom.c b/flashrom.c index 25e53f2..c8d477d 100644 --- a/flashrom.c +++ b/flashrom.c @@ -405,6 +405,18 @@ {0}, /* This entry corresponds to PROGRAMMER_INVALID. */ }; +/* This is a dummy probe for flash chips that cannot be probed for. */ +int probe_dummy(struct flashctx *flash) +{ + if (!chip_to_probe || strcmp(chip_to_probe, flash->chip->name)) { + msg_cdbg("Cant probe for this chip. Use 'flashrom -c %s' if you have one.\n", flash->chip->name); + return 0; + } + msg_cdbg("selected by user (Note: probing not possible or not implemented).\n"); + return 1; +} + + #define SHUTDOWN_MAXFN 32 static int shutdown_fn_count = 0; struct shutdown_func_data { -- To view, visit https://review.coreboot.org/19615 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I327400e337d6ce600c4f0f165f328715f5b341e2 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>

1 0

Change in flashrom[staging]: cli_common: Dont request reports from known-bad chip operations
by Urja Rannikko (Code Review) 07 May '17

07 May '17

Urja Rannikko has uploaded a new change for review. ( https://review.coreboot.org/19614 ) Change subject: cli_common: Dont request reports from known-bad chip operations ...................................................................... cli_common: Dont request reports from known-bad chip operations Change-Id: Ic4dc0d85534f2fcfe4dcb9733d4994c8853b48a7 Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M cli_common.c 1 file changed, 15 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/19614/1 diff --git a/cli_common.c b/cli_common.c index 71cc2dd..6bdc086 100644 --- a/cli_common.c +++ b/cli_common.c @@ -70,10 +70,12 @@ msg_cdbg("This chip's main memory can not be erased/written by design.\n"); } + if ((chip->tested.probe == BAD) || (chip->tested.probe == NT) || (chip->tested.read == BAD) || (chip->tested.read == NT) || (chip->tested.erase == BAD) || (chip->tested.erase == NT) || (chip->tested.write == BAD) || (chip->tested.write == NT)){ + int untested = 0; msg_cinfo("===\n"); if ((chip->tested.probe == BAD) || (chip->tested.read == BAD) || @@ -104,14 +106,20 @@ if (chip->tested.write == NT) msg_cinfo(" WRITE"); msg_cinfo("\n"); + untested = 1; } - msg_cinfo("The test status of this chip may have been updated in the latest development\n" - "version of flashrom. If you are running the latest development version,\n" - "please email a report to flashrom(a)flashrom.org if any of the above operations\n" - "work correctly for you with this flash chip. Please include the flashrom log\n" - "file for all operations you tested (see the man page for details), and mention\n" - "which mainboard or programmer you tested in the subject line.\n" - "Thanks for your help!\n"); + if (untested) { + msg_cinfo("The test status of this chip may have been updated in the latest development\n" + "version of flashrom. If you are running the latest development version,\n" + "please email a report to flashrom(a)flashrom.org if any of the above operations\n" + "work correctly for you with this flash chip. Please include the flashrom log\n" + "file for all operations you tested (see the man page for details), and mention\n" + "which mainboard or programmer you tested in the subject line.\n" + "Thanks for your help!\n"); + } else { + msg_cinfo("The test status of this chip may have been updated in the latest development\n" + "version of flashrom.\n"); + } } } -- To view, visit https://review.coreboot.org/19614 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4dc0d85534f2fcfe4dcb9733d4994c8853b48a7 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>

1 0

Change in flashrom[staging]: make args for -r/-w/-v non-positional and optional
by Nico Huber (Code Review) 04 May '17

04 May '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19387 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19387/3/flashrom.c File flashrom.c: Line 1367: chipoff_t len = entry->end - entry->start; `+ 1` -- To view, visit https://review.coreboot.org/19387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: layout: Add -i <region>[:<file>] support.
by Nico Huber (Code Review) 04 May '17

04 May '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19342 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 5: > Looks like the patching in of -i files for write support got lost during > rebase? Or maybe I just don't see where it happens... Found it in the next commit ;) -- To view, visit https://review.coreboot.org/19342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-PatchSet: 5 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: layout: Add -i <region>[:<file>] support.
by Nico Huber (Code Review) 04 May '17

04 May '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19342 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 5: Looks like the patching in of -i files for write support got lost during rebase? Or maybe I just don't see where it happens... -- To view, visit https://review.coreboot.org/19342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-PatchSet: 5 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by Arthur Heymans (Code Review) 04 May '17

04 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 13: Code-Review+1 Ok sry for this, fixed my ifd and it works fine. -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 13 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by Nico Huber (Code Review) 04 May '17

04 May '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/#/c/17953/13/ich_descriptors.c File ich_descriptors.c: PS13, Line 934: "Flash_Descriptor", : "BIOS", : "Intel_ME", : "GbE", : "Platform_Data" We should probably use the same names that `ifdtool -f` spits out. For any reason their version got merged faster :-P -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 13 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by Arthur Heymans (Code Review) 04 May '17

04 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/#/c/17953/13/ich_descriptors.c File ich_descriptors.c: PS13, Line 948: min(desc.content.NR + 1, ARRAY_SIZE(regions)) > In other words your GbE is at FLREGs[3]? like it usually is? but you ok makes sense -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 13 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by Nico Huber (Code Review) 04 May '17

04 May '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/#/c/17953/13/ich_descriptors.c File ich_descriptors.c: PS13, Line 948: min(desc.content.NR + 1, ARRAY_SIZE(regions)) > What I have is a Flash_Descriptor, a BIOS, and a GbE and no ME. content.NR In other words your GbE is at FLREGs[3]? like it usually is? but you exclude it by setting a short NR? Then fix your flash descriptor... -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 13 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2017