May 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: dediprog: Add socket support for SF600
by David Hendricks (Code Review) 12 May '17

12 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19673 to look at the new patch set (#2). Change subject: dediprog: Add socket support for SF600 ...................................................................... dediprog: Add socket support for SF600 This enables use of the socket rather than clip on SF600 programmers. Change-Id: I5fd4133f08882d60ac596273ab8aa9dab893c9cd Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M dediprog.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/19673/2 -- To view, visit https://review.coreboot.org/19673 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5fd4133f08882d60ac596273ab8aa9dab893c9cd Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: dediprog: Add socket support for SF600
by build bot (Jenkins) (Code Review) 12 May '17

12 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19673 ) Change subject: dediprog: Add socket support for SF600 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/301/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/307/ : SUCCESS -- To view, visit https://review.coreboot.org/19673 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fd4133f08882d60ac596273ab8aa9dab893c9cd Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: dediprog: Add socket support for SF600
by David Hendricks (Code Review) 12 May '17

12 May '17

David Hendricks has uploaded a new change for review. ( https://review.coreboot.org/19673 ) Change subject: dediprog: Add socket support for SF600 ...................................................................... dediprog: Add socket support for SF600 This enables use of the socket rather than clip on SF600 programmers. Change-Id: I5fd4133f08882d60ac596273ab8aa9dab893c9cd Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M dediprog.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/19673/1 diff --git a/dediprog.c b/dediprog.c index 6f82772..a579c1b 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1006,7 +1006,7 @@ free(target_str); return 1; } - if (target < 1 || target > 2) { + if (target < 1 || target > 3) { msg_perr("Error: Value for 'target' is out of range.\n"); free(target_str); return 1; @@ -1025,6 +1025,9 @@ msg_pinfo("Using target %s.\n", "FLASH_TYPE_APPLICATION_FLASH_2"); target = FLASH_TYPE_APPLICATION_FLASH_2; break; + case 3: + msg_pinfo("Using target %s.\n", "FLASH_TYPE_SOCKET"); + target = FLASH_TYPE_SOCKET; default: break; } @@ -1086,6 +1089,13 @@ dediprog_set_leds(LED_ALL); /* Select target/socket, frequency and VCC. */ + if (target == FLASH_TYPE_SOCKET) { + if (dediprog_devicetype != DEV_SF600) { + msg_perr("Socket flash is only supported on SF600.\n"); + return 1; + } + } + if (set_target_flash(target) || dediprog_set_spi_speed(spispeed_idx) || dediprog_set_spi_voltage(millivolt)) { -- To view, visit https://review.coreboot.org/19673 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5fd4133f08882d60ac596273ab8aa9dab893c9cd Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by Nico Huber (Code Review) 11 May '17

11 May '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17946 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 10: (1 comment) https://review.coreboot.org/#/c/17946/10/flash.h File flash.h: PS10, Line 142: /* TODO: Agree on a name and convert all occurences. > I think the scope of this struct has grown beyond context of the flash chip That depends on future design decisions, so I didn't want to go through a huge renaming twice. One question is, will we have one huge context for everything? or will we keep a per chip context that only lives from probing on? Stefan has patches to revise the probing btw (hadn't the time to look at them yet)... The current libflashrom interface suggests that we have two types of contexts `flashrom_programmer` and `flashrom_flashctx`. But we could still use a single context in the implementation. I just wanted to keep all options open. With that said, a next step could be to implement `flashrom_programmer` (starting with the flags, they really don't belong in the chip's context). With a single huge context, OTOH, we'd have aliases in the imple- mentation if we keep both structs in the interface (what I'd pre- fer). Then I'd agree to `flashrom_ctx` or `flashrom_context` in the implementation. In either case, we might want to look for a better name for `flashrom_flashctx` in the interface too. Maybe `flashrom_flash` or `flashrom_flashchip`? IMO, both would be a better match for `flashrom_programmer`. Last but not least, I don't want to annoy Stefan any further with unnecessary renaming atm. It would create a huge burden for anyone rebasing more invasive patches. And I think he's right with that. So we can discuss the names if you want, but I'd want to keep the alias until we have more of the larger patches in. -- To view, visit https://review.coreboot.org/17946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f169990830aa17b7dfae5eb74010d40c476181 Gerrit-PatchSet: 10 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by David Hendricks (Code Review) 11 May '17

11 May '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/17946 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 10: Code-Review-1 (1 comment) One last thing to bikeshed, otherwise LGTM. https://review.coreboot.org/#/c/17946/10/flash.h File flash.h: PS10, Line 142: /* TODO: Agree on a name and convert all occurences. I think the scope of this struct has grown beyond context of the flash chip. How about flashrom_ctx or flashrom_context? -- To view, visit https://review.coreboot.org/17946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f169990830aa17b7dfae5eb74010d40c476181 Gerrit-PatchSet: 10 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add functions to read/erase/write/verify by layout
by David Hendricks (Code Review) 11 May '17

11 May '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/17945 ) Change subject: Add functions to read/erase/write/verify by layout ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/17945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6194cea4c4c430e0cf9d586052508a865b09c86 Gerrit-PatchSet: 10 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Give layouts their own type
by David Hendricks (Code Review) 11 May '17

11 May '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/17944 ) Change subject: Give layouts their own type ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/17944 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icea1a58c283131cc9c5fde6f16d783538dc1a4c7 Gerrit-PatchSet: 6 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add a generic 27C256 definition (32k UV EPROM)
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19616 ) Change subject: Add a generic 27C256 definition (32k UV EPROM) ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/300/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/305/ : SUCCESS -- To view, visit https://review.coreboot.org/19616 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie726ff252bc398d78e76bfb5ed01359341b734f3 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add probe_dummy for chips that are not practical to probe
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19615 ) Change subject: Add probe_dummy for chips that are not practical to probe ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/299/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/306/ : SUCCESS -- To view, visit https://review.coreboot.org/19615 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I327400e337d6ce600c4f0f165f328715f5b341e2 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in flashrom[staging]: cli_common: Dont request reports from known-bad chip operations
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19614 ) Change subject: cli_common: Dont request reports from known-bad chip operations ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/298/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/304/ : SUCCESS -- To view, visit https://review.coreboot.org/19614 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4dc0d85534f2fcfe4dcb9733d4994c8853b48a7 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2017