Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/19531 )
Change subject: Fix erase block structure on Spansion S25FL128P
......................................................................
Patch Set 2:
> I think what you have is a S25FL128P......0 the 0 marks 64KiB
> sectors.
The exact part number printed on the Flash chip is:
Spansion FL128P1F
Is the "P1" a red herring? If so, perhaps the Flashrom sources need a comment to help with this confusing aspect of the device naming.
--
To view, visit https://review.coreboot.org/19531
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b4e3673f7019f38a3b6ab2f7002bbe56dc6de07
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: stable
Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Nico Huber has posted comments on this change. ( https://review.coreboot.org/19531 )
Change subject: Fix erase block structure on Spansion S25FL128P
......................................................................
Patch Set 2: Code-Review-1
I think what you have is a S25FL128P......0 the 0 marks 64KiB sectors.
--
To view, visit https://review.coreboot.org/19531
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b4e3673f7019f38a3b6ab2f7002bbe56dc6de07
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: stable
Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19530
to look at the new patch set (#2).
Change subject: Add support for programming SPI devices attached to the AST1100 BMC
......................................................................
Add support for programming SPI devices attached to the AST1100 BMC
All possible (three) Flash devices are supported with the programmer-
specific parameter spibus=<n>. The AST2050 device is compatible with
this driver.
Read and write tested on ASUS KGPE-D16 with ASMB4 BMC module installed.
Change-Id: I5b17061a7f308eabe50d87127311dc88cc96e16c
Signed-off-by: Timothy Pearson <tpearson(a)raptorengineering.com>
---
M Makefile
A ast1100.c
M ast2400.c
M flashrom.c
M programmer.h
5 files changed, 530 insertions(+), 93 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/19530/2
--
To view, visit https://review.coreboot.org/19530
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5b17061a7f308eabe50d87127311dc88cc96e16c
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: stable
Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins)