October 2017 - flashrom-gerrit

Change in flashrom[staging]: Use bzip2 when making a tarball
by build bot (Jenkins) (Code Review) 21 Oct '17

21 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22116 ) Change subject: Use bzip2 when making a tarball ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/800/ : SUCCESS -- To view, visit https://review.coreboot.org/22116 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Gerrit-Change-Number: 22116 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Oct 2017 02:15:50 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Use bzip2 when making a tarball
by David Hendricks (Code Review) 21 Oct '17

21 Oct '17

Hello Stefan Tauner, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/22116 to look at the new patch set (#2). Change subject: Use bzip2 when making a tarball ...................................................................... Use bzip2 when making a tarball Tarballs on download.flashrom.org are generally packaged using bzip2, so we may as well be internally consistent. Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M Makefile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/22116/2 -- To view, visit https://review.coreboot.org/22116 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Gerrit-Change-Number: 22116 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by build bot (Jenkins) (Code Review) 20 Oct '17

20 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21934 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/799/ : SUCCESS -- To view, visit https://review.coreboot.org/21934 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Gerrit-Change-Number: 21934 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 19:27:20 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by Nico Huber (Code Review) 20 Oct '17

20 Oct '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21934 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... fixup! nicintel_eeprom: Support for I210 emulated EEprom Fix is_i210(), add a comment and break an overlong line. Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/21934 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M nicintel_eeprom.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index e4a91ef..c787580 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -80,6 +80,10 @@ #define UNPROG_DEVICE 0x1509 +/* + * Warning: is_i210() below makes assumptions on these PCI ids. + * It may have to be updated when this list is extended. + */ const struct dev_entry nics_intel_ee[] = { {PCI_VENDOR_ID_INTEL, 0x150e, OK, "Intel", "82580 Quad Gigabit Ethernet Controller (Copper)"}, {PCI_VENDOR_ID_INTEL, 0x150f, NT , "Intel", "82580 Quad Gigabit Ethernet Controller (Fiber)"}, @@ -99,7 +103,7 @@ static inline bool is_i210(uint16_t device_id) { - return (device_id & 0xff00) == 0x1500; + return (device_id & 0xfff0) == 0x1530; } static int nicintel_ee_probe_i210(struct flashctx *flash) @@ -218,7 +222,8 @@ return -1; } -static int nicintel_ee_write_i210(struct flashctx *flash, const uint8_t *buf, unsigned int addr, unsigned int len) +static int nicintel_ee_write_i210(struct flashctx *flash, const uint8_t *buf, + unsigned int addr, unsigned int len) { done_i20_write = true; -- To view, visit https://review.coreboot.org/21934 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Gerrit-Change-Number: 21934 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: nicintel_eeprom: Reduce usage of is_i210()
by David Hendricks (Code Review) 20 Oct '17

20 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21935 ) Change subject: nicintel_eeprom: Reduce usage of is_i210() ...................................................................... Patch Set 2: Code-Review+2 Either way seems fine w/ me as well. It might be good to send a pull request to https://github.com/ribalda/flashrom to see what the author thinks. -- To view, visit https://review.coreboot.org/21935 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I59164ccf54afbbd64a0598282d13e80ff7fd6fa4 Gerrit-Change-Number: 21935 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 18:57:41 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by David Hendricks (Code Review) 20 Oct '17

20 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21934 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c File nicintel_eeprom.c: https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106 PS1, Line 106: return (device_id & 0xfff0) == 0x1530; > As this was supposed to be a fixup!, I tried to anticipate what SGTM. As the file is written, your fixup! seems correct. If needed we can follow-up with a patch to check for other possible device IDs - perhaps by checking more raw values here or by adding an enum to nics_intel_ee[] to indicate the device's family (I210, I82580, etc) and iterating thru. -- To view, visit https://review.coreboot.org/21934 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Gerrit-Change-Number: 21934 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 18:13:26 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Use bzip2 when making tarball
by Nico Huber (Code Review) 20 Oct '17

20 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22116 ) Change subject: Use bzip2 when making tarball ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22116 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Gerrit-Change-Number: 22116 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 15:31:19 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by Nico Huber (Code Review) 20 Oct '17

20 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21934 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c File nicintel_eeprom.c: https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106 PS1, Line 106: return (device_id & 0xfff0) == 0x1530; > Are you sure about this? 0x157b and 0x157c seem valid in addition to 0x153x As this was supposed to be a fixup!, I tried to anticipate what the author intended. And, as the comment suggests, this is not supposed to be future proof. Anyway, `device_id >= 0x1530` should work as well (but doesn't align with current nicintel_spi.c). -- To view, visit https://review.coreboot.org/21934 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Gerrit-Change-Number: 21934 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 15:19:12 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by David Hendricks (Code Review) 20 Oct '17

20 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21934 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c File nicintel_eeprom.c: https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106 PS1, Line 106: return (device_id & 0xfff0) == 0x1530; Are you sure about this? 0x157b and 0x157c seem valid in addition to 0x153x: http://pci-ids.ucw.cz/v2.2/pci.ids -- To view, visit https://review.coreboot.org/21934 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Gerrit-Change-Number: 21934 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 09:34:54 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Use bzip2 when making tarball
by build bot (Jenkins) (Code Review) 19 Oct '17

19 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22116 ) Change subject: Use bzip2 when making tarball ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/708/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/798/ : SUCCESS -- To view, visit https://review.coreboot.org/22116 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib9fb1ea6d5994cd0285ce8db9675640fae992773 Gerrit-Change-Number: 22116 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 19 Oct 2017 22:05:44 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2017