David Hendricks has posted comments on this change. ( https://review.coreboot.org/21935 )
Change subject: nicintel_eeprom: Reduce usage of is_i210()
......................................................................
Patch Set 2: Code-Review+2
Either way seems fine w/ me as well. It might be good to send a pull request to https://github.com/ribalda/flashrom to see what the author thinks.
--
To view, visit
https://review.coreboot.org/21935
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I59164ccf54afbbd64a0598282d13e80ff7fd6fa4
Gerrit-Change-Number: 21935
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Oct 2017 18:57:41 +0000
Gerrit-HasComments: No