Nico Huber has posted comments on this change. ( https://review.coreboot.org/19418 )
Change subject: spi: Add valid_addr_offset() to spi_master
......................................................................
Patch Set 3: Code-Review-1
The patch is fine, but doesn't solve the real problem:
spi_get_valid_read_addr() shouldn't exist. We are testing
something programmer specific right before giving control
to the programmer driver... ichspi should just test this.
--
To view, visit https://review.coreboot.org/19418
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbac513c5339e8aff624870252133284ef85ab73
Gerrit-Change-Number: 19418
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 16 Oct 2017 17:03:14 +0000
Gerrit-HasComments: No
David Hendricks has posted comments on this change. ( https://review.coreboot.org/19387 )
Change subject: make args for -r/-w/-v non-positional and optional
......................................................................
Patch Set 7:
Sure - I'll see if I can untangle it.
--
To view, visit https://review.coreboot.org/19387
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 19387
Gerrit-PatchSet: 7
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 16 Oct 2017 16:55:32 +0000
Gerrit-HasComments: No
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21920 )
Change subject: Fix ID of ST M25P05
......................................................................
Fix ID of ST M25P05
The (old) ST (now Micron) M25P05 does only support RES for identification.
Unfortunately, the vendor datasheet states the same ID as for the M25P10
(0x10) and thus flashrom has treated these two as evil twins in the past.
However, real hardware confirmed that the real ID of this chip is 0x05.
Change-Id: Idc75f8cb98e7ef0c47c4527cedcc4da3723bd779
Signed-off-by: Serge Vasilugin <vasilugin(a)yandex.ru>
Tested-by: Serge Vasilugin <vasilugin(a)yandex.ru>
Reviewed-on: https://review.coreboot.org/21920
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M flashchips.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Nico Huber: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/flashchips.h b/flashchips.h
index bff0c98..62eb9a5 100644
--- a/flashchips.h
+++ b/flashchips.h
@@ -749,9 +749,9 @@
*/
#define ST_ID 0x20 /* ST / SGS/Thomson / Numonyx (later acquired by Micron) */
#define ST_M25P05A 0x2010
-#define ST_M25P05_RES 0x10 /* Same code as M25P10. */
+#define ST_M25P05_RES 0x05
#define ST_M25P10A 0x2011
-#define ST_M25P10_RES 0x10 /* Same code as M25P05. */
+#define ST_M25P10_RES 0x10
#define ST_M25P20 0x2012
#define ST_M25P20_RES 0x11
#define ST_M25P40 0x2013
--
To view, visit https://review.coreboot.org/21920
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc75f8cb98e7ef0c47c4527cedcc4da3723bd779
Gerrit-Change-Number: 21920
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/19387 )
Change subject: make args for -r/-w/-v non-positional and optional
......................................................................
Patch Set 7:
The changes to flashrom.c and layout.c seem to belong into the previous
commit. If it's too hard to untangle, maybe just squash them?
--
To view, visit https://review.coreboot.org/19387
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 19387
Gerrit-PatchSet: 7
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 15 Oct 2017 16:27:46 +0000
Gerrit-HasComments: No
Nico Huber has posted comments on this change. ( https://review.coreboot.org/19857 )
Change subject: spi: add opcodes for fast read and 4BA direct read
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19857/1/spi4ba.h
File spi4ba.h:
https://review.coreboot.org/#/c/19857/1/spi4ba.h@57
PS1, Line 57: #define JEDEC_READ_4BA_DIRECT 0x0c
> What makes this more direct than the JEDEC_READ_4BA above? Isn't
After looking at the Dediprog patch, this seems to be fast read.
--
To view, visit https://review.coreboot.org/19857
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6dfab2dc48379b9b9c0d0a7551f9d294ce0a23a
Gerrit-Change-Number: 19857
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 15 Oct 2017 16:13:54 +0000
Gerrit-HasComments: Yes
Nico Huber has posted comments on this change. ( https://review.coreboot.org/19857 )
Change subject: spi: add opcodes for fast read and 4BA direct read
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19857/1/spi4ba.h
File spi4ba.h:
https://review.coreboot.org/#/c/19857/1/spi4ba.h@57
PS1, Line 57: #define JEDEC_READ_4BA_DIRECT 0x0c
What makes this more direct than the JEDEC_READ_4BA above? Isn't
it the same with a different opcode?
--
To view, visit https://review.coreboot.org/19857
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6dfab2dc48379b9b9c0d0a7551f9d294ce0a23a
Gerrit-Change-Number: 19857
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 15 Oct 2017 15:17:38 +0000
Gerrit-HasComments: Yes