David Hendricks has posted comments on this change. ( https://review.coreboot.org/21934 )
Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c File nicintel_eeprom.c:
https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106 PS1, Line 106: return (device_id & 0xfff0) == 0x1530;
As this was supposed to be a fixup!, I tried to anticipate what
SGTM. As the file is written, your fixup! seems correct.
If needed we can follow-up with a patch to check for other possible device IDs - perhaps by checking more raw values here or by adding an enum to nics_intel_ee[] to indicate the device's family (I210, I82580, etc) and iterating thru.
-
David Hendricks (Code Review)