Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom - flashrom-gerrit

20 Oct 2017


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/21934 )
Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c
File nicintel_eeprom.c:
https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106
PS1, Line 106: return (device_id & 0xfff0) == 0x1530;
Are you sure about this? 0x157b and 0x157c seem valid in addition to 0x153x: http://pci-ids.ucw.cz/v2.2/pci.ids
-- 
To view, visit https://review.coreboot.org/21934
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3
Gerrit-Change-Number: 21934
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Oct 2017 09:34:54 +0000
Gerrit-HasComments: Yes