Attention is currently required from: Felix Singer, Nico Huber, Richard Hughes.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 )
Change subject: libflashrom: Allow getting the progress_state from the flashctx
......................................................................
Patch Set 2:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/64663/comment/41837e5f_193e454c
PS2, Line 70: return flashctx->progress_state;
I don't know flashrom's policy on this, but shouldn't flashctx be guarded against null? Or should th […]
I read your comment and started thinking about this too. I went through this file, I don't see many examples of flashctx be guarded against null, it almost never done. Maybe I misunderstand you, what do you mean by "it's done elsewhere in this file too"? thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Comment-Date: Fri, 27 May 2022 04:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment