Change in flashrom[master]: libflashrom: Allow getting the progress_state from the flashctx

[Felix Singer (Code Review)]

Attention is currently required from: Richard Hughes.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 )

Change subject: libflashrom: Allow getting the progress_state from the flashctx
......................................................................


Patch Set 2:

(1 comment)

File libflashrom.c:

https://review.coreboot.org/c/flashrom/+/64663/comment/2887e5cb_dfdaae27 
PS2, Line 70: 	return flashctx->progress_state;
I don't know flashrom's policy on this, but shouldn't flashctx be guarded against null? Or should the user check for null before calling the function? At least it's done elsewhere in this file too.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/64663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Daniel Campello <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Sean Rhodes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Thomas Heijligen <[e-mail]>
Gerrit-Attention: Richard Hughes <[e-mail]>
Gerrit-Comment-Date: Fri, 27 May 2022 01:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment