Attention is currently required from: Richard Hughes.
View Change
1 comment:
File libflashrom.c:
Patch Set #2, Line 70: return flashctx->progress_state;
I don't know flashrom's policy on this, but shouldn't flashctx be guarded against null? Or should the user check for null before calling the function? At least it's done elsewhere in this file too.
To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes <richard@hughsie.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Sean Rhodes <sean@starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Richard Hughes <richard@hughsie.com>
Gerrit-Comment-Date: Fri, 27 May 2022 01:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment