Attention is currently required from: Felix Singer, Nico Huber, Richard Hughes.

View Change

1 comment:

• File libflashrom.c:

  • Patch Set #2, Line 70: return flashctx->progress_state;

    I don't know flashrom's policy on this, but shouldn't flashctx be guarded against null? Or should th […]

    I read your comment and started thinking about this too. I went through this file, I don't see many examples of flashctx be guarded against null, it almost never done. Maybe I misunderstand you, what do you mean by "it's done elsewhere in this file too"? thanks!

To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.