Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62319 )
Change subject: tests/linux_spi: Validate param file path ......................................................................
Patch Set 8:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62319/comment/fe852565_a54d1f83 PS4, Line 7: Validate param file path
Sorry I missed in the first batch of comments. […]
Even when the platform supports multiple paths (for multiple calls to open) here there is a single call with a single path. I think title is descriptive as is.
https://review.coreboot.org/c/flashrom/+/62319/comment/a8bdd83e_99e3dbfd PS4, Line 10: linux_spi unit-test does not : check
I think unit-tests in general had no implementation to mock repeated calls to open, it is not specif […]
Done
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/62319/comment/f674532d_e6cc0d60 PS4, Line 39: #define DEFAULT_MOCK_FD 0xC0FE
You can rebase on top of https://review.coreboot. […]
Done
https://review.coreboot.org/c/flashrom/+/62319/comment/500d2b87_cdf3d152 PS4, Line 41: default_io_mock_state
I have rebased with 'fallback' instead. […]
Ack
https://review.coreboot.org/c/flashrom/+/62319/comment/89a096a7_dbfbaa58 PS4, Line 48: default_open
For the same reasons as above, I would rename this to something more self-explanatory, maybe "multip […]
Ack
https://review.coreboot.org/c/flashrom/+/62319/comment/52049d09_85732e28 PS4, Line 305: data
Ok, this is existing pattern that was reviewed and approved by everyone, that's why I suggested it. […]
Done
File tests/wraps.c:
https://review.coreboot.org/c/flashrom/+/62319/comment/b58c15bc_ec39dd43 PS5, Line 26: assert_int_equal(flags & io_state->flags, io_state->flags);
flags may be different for each path
Done
-
Daniel Campello (Code Review)