Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.

7 comments:

Commit Message:
- Patch Set #4, Line 7: Validate param file path
  Sorry I missed in the first batch of comments. […]
  Even when the platform supports multiple paths (for multiple calls to open) here there is a single call with a single path. I think title is descriptive as is.
- Patch Set #4, Line 10:
```
linux_spi unit-test does not
check
```
  I think unit-tests in general had no implementation to mock repeated calls to open, it is not specif […]
  Done
File tests/init_shutdown.c:
- Patch Set #4, Line 39: #define DEFAULT_MOCK_FD 0xC0FE
  You can rebase on top of https://review.coreboot. […]
  Done
- Patch Set #4, Line 41: default_io_mock_state
  I have rebased with 'fallback' instead. […]
  Ack
- Patch Set #4, Line 48: default_open
  For the same reasons as above, I would rename this to something more self-explanatory, maybe "multip […]
  Ack
- Patch Set #4, Line 305: data
  Ok, this is existing pattern that was reviewed and approved by everyone, that's why I suggested it. […]
  Done
File tests/wraps.c:
- Patch Set #5, Line 26: assert_int_equal(flags & io_state->flags, io_state->flags);
  flags may be different for each path
  Done

To view, visit change 62319. To unsubscribe, or for help writing mail filters, visit settings.