Change in flashrom[master]: tests/: Allow for file path validation

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62320 ) Change subject: tests/: Allow for file path validation ...................................................................... Patch Set 8: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62320/comment/f69d298b_8888475b PS4, Line 7: Allow for file path validation
I added some comments about commit messages in previous patches, this one would need to be aligned a […] Again, no multiple paths even when they are supported by the framework.
File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/62320/comment/12992ca2_a0c86ca4 PS4, Line 61: data
Why dummy needs mocks? This is unexpected [to me]. This is actually making sure that no open() calls are made.
https://review.coreboot.org/c/flashrom/+/62320/comment/cb76970d_d3c21b63 PS4, Line 80: data
Same comment as in previous patches: let's be more specific with naming and call this `nicrealtek_io […] Done
https://review.coreboot.org/c/flashrom/+/62320/comment/e19c58ea_5ef5005f PS4, Line 89:
Lets add new line before and after `io_mock_register` Done
https://review.coreboot.org/c/flashrom/+/62320/comment/b35a2d1b_9d12bac8 PS4, Line 90:
Since this test now registering io mock, it also needs to unregister, which is […] Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/62320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I892fa1ecee26ebce9640893edbb228fa9aa7b0b6 Gerrit-Change-Number: 62320 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Thu, 31 Mar 2022 04:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Daniel Campello (Code Review)