David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 )
Change subject: libflashrom.h: Remove line breaks in function signatures ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h:
https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length);
I couldn't find anything in the wiki either. Not buried too deep for my […]
Ah, here we go: https://mail.coreboot.org/pipermail/flashrom/2012-May/009228.html
I think the tl;dr version is: - 80 columns soft limit - 112 columns hard limit - Tables are an exception and may be as long as needed for readability
I went ahead and added this to the wiki: https://www.flashrom.org/Development_Guidelines#Coding_style
I'll ping the mailing list as well in case others wish to add stuff or argue about those limits.
-
David Hendricks (Code Review)