Patch Set 1:

(1 comment)

View Change

1 comment:

• File libflashrom.h:

  • Patch Set #1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length);

    I couldn't find anything in the wiki either. Not buried too deep for my […]

    Ah, here we go: https://mail.coreboot.org/pipermail/flashrom/2012-May/009228.html

    I think the tl;dr version is:

    • 80 columns soft limit
    • 112 columns hard limit
    • Tables are an exception and may be as long as needed for readability

    I went ahead and added this to the wiki: https://www.flashrom.org/Development_Guidelines#Coding_style

    I'll ping the mailing list as well in case others wish to add stuff or argue about those limits.

To view, visit change 30154. To unsubscribe, or for help writing mail filters, visit settings.