Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/1
diff --git a/cli_classic.c b/cli_classic.c index b4112fd..4604043 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -101,6 +101,7 @@ #if CONFIG_PRINT_WIKI == 1 int list_supported_wiki = 0; #endif + int flash_name = 0; int read_it = 0, write_it = 0, erase_it = 0, verify_it = 0; int dont_verify_it = 0, dont_verify_all = 0, list_supported = 0, operation_specified = 0; struct flashrom_layout *layout = NULL; @@ -110,6 +111,7 @@ OPTION_FMAP, OPTION_FMAP_FILE, OPTION_FLASH_CONTENTS, + OPTION_FLASH_NAME, }; int ret = 0;
@@ -130,6 +132,7 @@ {"fmap-file", 1, NULL, OPTION_FMAP_FILE}, {"image", 1, NULL, 'i'}, {"flash-contents", 1, NULL, OPTION_FLASH_CONTENTS}, + {"flash-name", 0, NULL, OPTION_FLASH_NAME}, {"list-supported", 0, NULL, 'L'}, {"list-supported-wiki", 0, NULL, 'z'}, {"programmer", 1, NULL, 'p'}, @@ -296,6 +299,9 @@ case OPTION_FLASH_CONTENTS: referencefile = strdup(optarg); break; + case OPTION_FLASH_NAME: + flash_name = 1; + break; case 'L': if (++operation_specified > 1) { fprintf(stderr, "More than one operation " @@ -602,11 +608,23 @@ goto out_shutdown; }
- if (!(read_it | write_it | verify_it | erase_it)) { + if (!(read_it | write_it | verify_it | erase_it | flash_name)) { msg_ginfo("No operations were specified.\n"); goto out_shutdown; }
+ if (flash_name) { + if (fill_flash->chip->vendor && fill_flash->chip->name) { + msg_ginfo("vendor"%s" name="%s"\n", + fill_flash->chip->vendor, + fill_flash->chip->name); + goto out_shutdown; + } else { + ret = -1; + goto out_shutdown; + } + } + if (layoutfile) { layout = get_global_layout(); } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) ||
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@303 PS1, Line 303: flash_name = 1; Please add a check for mutliple operations specified, like the other operations have it:
if (++operations_specified > 1) { ...
Maybe it's time to put that block into a separate function?
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@618 PS1, Line 618: msg_ginfo("vendor"%s" name="%s"\n", I wonder if we don't want to use printf() directly. It shouldn't depend on the message level, should it?
Hello Alan Green, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#2).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Contrain number_of_operations to one as per Nico's comment.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 2:
(2 comments)
Thanks for the quick review Nico!
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@303 PS1, Line 303: flash_name = 1;
Please add a check for mutliple operations specified, like the […]
Done and in the follow on for --get-size as well. Thanks for catching that!
Regarding separate function. I think I am going to prepare some cleanups around the cli, I find it too stateful. I have this idea of a function that determines the args and packs a struct that we can query in the main(). I'll prepare something on top of these simpler patches.
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@618 PS1, Line 618: msg_ginfo("vendor"%s" name="%s"\n",
I wonder if we don't want to use printf() directly. It shouldn't […]
Am I mistaken to think info is always printed and so it is good to channel everything though it? I have no strong feelings either way..
Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/3/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/3/cli_classic.c@626 PS3, Line 626: goto out_shutdown; Nit: This could go outside of the if/else scope
Hello Angel Pons, Alan Green, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#4).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/4
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 4:
(1 comment)
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/3/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/3/cli_classic.c@626 PS3, Line 626: goto out_shutdown;
Nit: This could go outside of the if/else scope
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 4: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/35591/4//COMMIT_MSG@9 PS4, Line 9: We have this It would be useful to add ...
1. what the option does 2. an example how to use it.
Hello Angel Pons, build bot (Jenkins), Alan Green, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#5).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
This option prints the detected flashchips name such as in the case of: `flashrom -p internal --flash-name`.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/5
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 5:
(1 comment)
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/35591/4//COMMIT_MSG@9 PS4, Line 9: We have this
It would be useful to add ... […]
Done
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 5: Code-Review+2
Looks good, if we agree that we generally want to merge this.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/4/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/4/cli_classic.c@305 PS4, Line 305: "specified. Aborting.\n"); Should fit on one line?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/4/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/4/cli_classic.c@305 PS4, Line 305: "specified. Aborting.\n");
Should fit on one line?
Fits current codebase conventions, see `case 'L':` for example, and my comment in the follow on patch.
Hello Angel Pons, David Hendricks, Stefan Reinauer, build bot (Jenkins), Alan Green, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#6).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block. V.4: Add missing --help line.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/6
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 6:
(1 comment)
Please also update the manpage.
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@618 PS1, Line 618: msg_ginfo("vendor"%s" name="%s"\n",
Am I mistaken to think info is always printed and so it is good to channel everything though it? I h […]
Info is always printed, yes. Currently! If one ever wanted to change that, should they search the whole code base for such cases? I have to admit, one would actually only have to search UI code, but still, we can avoid that.
I'm not even sure if we should ever use our msg*() functions in this file.
Hello Angel Pons, David Hendricks, Stefan Reinauer, build bot (Jenkins), Alan Green, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#7).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block. V.4: Add missing --help line. V.5: Add man page entry.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/7
Hello Angel Pons, David Hendricks, Stefan Reinauer, build bot (Jenkins), Alan Green, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#8).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block. V.4: Add missing --help line. V.5: Add man page entry.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 35 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/8
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/8/flashrom.8.tmpl File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/35591/8/flashrom.8.tmpl@248 PS8, Line 248: chips chip's ?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35591/8/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/8/cli_classic.c@624 PS8, Line 624: vendor missing = ? vendor=
Hello Angel Pons, David Hendricks, Stefan Reinauer, build bot (Jenkins), Alan Green, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35591
to look at the new patch set (#9).
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block. V.4: Add missing --help line. V.5: Add man page entry. v.6: Use printf() directly.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 35 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35591/9
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@618 PS1, Line 618: msg_ginfo("vendor"%s" name="%s"\n",
Info is always printed, yes. Currently! If one ever wanted to change […]
Done
https://review.coreboot.org/c/flashrom/+/35591/8/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/8/cli_classic.c@624 PS8, Line 624: vendor
missing = ? vendor=
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 9: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
cli_classic: Add convenient '--flash-name' cli opt
We have this in the ChromiumOS fork of flashrom which we rely on to obtain the current flash chip in use. This ports it for upstream consumption.
V.2: Constrain number_of_operations to one as per Nico's comment. V.3: Move two goto's outside inner if-else block. V.4: Add missing --help line. V.5: Add man page entry. v.6: Use printf() directly.
Change-Id: I23d574a2f8eaf809a5c0524490db9e3a560ede56 Signed-off-by: Edward O'Callaghan quasisec@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/35591 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M cli_classic.c M flashrom.8.tmpl 2 files changed, 35 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/cli_classic.c b/cli_classic.c index b4112fd..5dff904 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -51,6 +51,7 @@ " -n | --noverify don't auto-verify\n" " -N | --noverify-all verify included regions only (cf. -i)\n" " -l | --layout <layoutfile> read ROM layout from <layoutfile>\n" + " --flash-name read out the detected flash name\n" " --fmap read ROM layout from fmap embedded in ROM\n" " --fmap-file <fmapfile> read ROM layout from fmap in <fmapfile>\n" " --ifd read layout from an Intel Firmware Descriptor\n" @@ -101,6 +102,7 @@ #if CONFIG_PRINT_WIKI == 1 int list_supported_wiki = 0; #endif + int flash_name = 0; int read_it = 0, write_it = 0, erase_it = 0, verify_it = 0; int dont_verify_it = 0, dont_verify_all = 0, list_supported = 0, operation_specified = 0; struct flashrom_layout *layout = NULL; @@ -110,6 +112,7 @@ OPTION_FMAP, OPTION_FMAP_FILE, OPTION_FLASH_CONTENTS, + OPTION_FLASH_NAME, }; int ret = 0;
@@ -130,6 +133,7 @@ {"fmap-file", 1, NULL, OPTION_FMAP_FILE}, {"image", 1, NULL, 'i'}, {"flash-contents", 1, NULL, OPTION_FLASH_CONTENTS}, + {"flash-name", 0, NULL, OPTION_FLASH_NAME}, {"list-supported", 0, NULL, 'L'}, {"list-supported-wiki", 0, NULL, 'z'}, {"programmer", 1, NULL, 'p'}, @@ -296,6 +300,14 @@ case OPTION_FLASH_CONTENTS: referencefile = strdup(optarg); break; + case OPTION_FLASH_NAME: + if (++operation_specified > 1) { + fprintf(stderr, "More than one operation " + "specified. Aborting.\n"); + cli_classic_abort_usage(); + } + flash_name = 1; + break; case 'L': if (++operation_specified > 1) { fprintf(stderr, "More than one operation " @@ -602,11 +614,22 @@ goto out_shutdown; }
- if (!(read_it | write_it | verify_it | erase_it)) { + if (!(read_it | write_it | verify_it | erase_it | flash_name)) { msg_ginfo("No operations were specified.\n"); goto out_shutdown; }
+ if (flash_name) { + if (fill_flash->chip->vendor && fill_flash->chip->name) { + printf("vendor="%s" name="%s"\n", + fill_flash->chip->vendor, + fill_flash->chip->name); + } else { + ret = -1; + } + goto out_shutdown; + } + if (layoutfile) { layout = get_global_layout(); } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) || diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 30dc97d..7002c72 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -44,10 +44,12 @@ .SH NAME flashrom - detect, read, write, verify and erase flash chips .SH SYNOPSIS -.B flashrom \fR[\fB-h\fR|\fB-R\fR|\fB-L\fR|\fB-z\fR|\fB-p\fR <programmername>[:<parameters>] - [\fB-E\fR|\fB-r\fR <file>|\fB-w\fR <file>|\fB-v\fR <file>] [\fB-c\fR <chipname>] - [(\fB-l\fR <file>|\fB--ifd|\fB --fmap\fR|\fB--fmap-file\fR <file>) [\fB-i\fR <image>]] - [\fB-n\fR] [\fB-N\fR] [\fB-f\fR]] +.B flashrom \fR[\fB-h\fR|\fB-R\fR|\fB-L\fR|\fB-z\fR| + \fB-p\fR <programmername>[:<parameters>] [\fB-c\fR <chipname>] + (\fB--flash-name\fR| + [\fB-E\fR|\fB-r\fR <file>|\fB-w\fR <file>|\fB-v\fR <file>] + [(\fB-l\fR <file>|\fB--ifd|\fB --fmap\fR|\fB--fmap-file\fR <file>) [\fB-i\fR <image>]] + [\fB-n\fR] [\fB-N\fR] [\fB-f\fR])] [\fB-V\fR[\fBV\fR[\fBV\fR]]] [\fB-o\fR <logfile>] .SH DESCRIPTION .B flashrom @@ -242,6 +244,9 @@ .B <imagename> from flash layout. .TP +.B "--flash-name" +Prints out the detected flash chips name. +.TP .B "-L, --list-supported" List the flash chips, chipsets, mainboards, and external programmers (including PCI, USB, parallel port, and serial port based devices) @@ -1335,6 +1340,8 @@ .br Dominik Geyer .br +Edward O'Callaghan +.br Eric Biederman .br Giampiero Giancipoli
Antonio Ospite has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 10:
(1 comment)
Just a minor comment on the commit message. Keep up the good work!
https://review.coreboot.org/c/flashrom/+/35591/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/35591/10//COMMIT_MSG@17 PS10, Line 17: v.6: Use printf() directly. Hi Edward,
IMHO it is not necessary to put the review history in commit messages.
And even less so in a gerrit workflow as it's all in gerrit already, right?
Ciao, Antonio
-
Alan Green (Code Review) -
Angel Pons (Code Review)
-
Antonio Ospite (Code Review)
-
David Hendricks (Code Review)
-
Edward O'Callaghan (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)