View Change

2 comments:

• File cli_classic.c:

  • Patch Set #1, Line 303: flash_name = 1;

    Please add a check for mutliple operations specified, like the
    other operations have it:

        if (++operations_specified > 1) {
                ...

    Maybe it's time to put that block into a separate function?

  • Patch Set #1, Line 618: msg_ginfo("vendor\"%s\" name=\"%s\"\n",

    I wonder if we don't want to use printf() directly. It shouldn't
    depend on the message level, should it?

To view, visit change 35591. To unsubscribe, or for help writing mail filters, visit settings.