Thanks for the quick review Nico!
Patch Set #1, Line 303:
flash_name = 1;
Please add a check for mutliple operations specified, like the […]
Done and in the follow on for --get-size as well. Thanks for catching that!
Regarding separate function. I think I am going to prepare some cleanups around the cli, I find it too stateful. I have this idea of a function that determines the args and packs a struct that we can query in the main(). I'll prepare something on top of these simpler patches.
Patch Set #1, Line 618:
I wonder if we don't want to use printf() directly. It shouldn't […]
Am I mistaken to think info is always printed and so it is good to channel everything though it? I have no strong feelings either way..
To view, visit change 35591. To unsubscribe, or for help writing mail filters, visit settings.