[L] Change in flashrom[master]: flashrom.c: Add functions for new erase selction algorithm

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Simon Buhrow, Aarya, Anastasia Klimchuk.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )

Change subject: flashrom.c: Add functions for new erase selction algorithm
......................................................................


Patch Set 86:

(8 comments)

Patchset:

PS86: 
relatively minor stuff now, we can still iterate in tree however the more const correctness the better. The more expensive you can be with types the better it communicates your intentions of your code to the compiler - e.g., modifying a loop upper bound you intended to be const.


File erasure_layout.c:

https://review.coreboot.org/c/flashrom/+/65844/comment/d94201de_4922fcfd 
PS86, Line 114: s
`const`


https://review.coreboot.org/c/flashrom/+/65844/comment/2bd74227_c520ebbf 
PS86, Line 130: size_t num;
delete


https://review.coreboot.org/c/flashrom/+/65844/comment/4565cf95_70abb9fd 
PS86, Line 133: (
`size_t num = 0;`


https://review.coreboot.org/c/flashrom/+/65844/comment/68295e89_cb982826 
PS86, Line 165: const unsigned int
`const size_t`?


https://review.coreboot.org/c/flashrom/+/65844/comment/8b486bf7_7f20a426 
PS86, Line 166: unsigned int
and this `size_t` too?


https://review.coreboot.org/c/flashrom/+/65844/comment/d39e3d42_f18e6113 
PS86, Line 216: int
`const int` ?


https://review.coreboot.org/c/flashrom/+/65844/comment/e15ee17e_8171ecc3 
PS86, Line 217: int 
`const int` ?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/65844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256
Gerrit-Change-Number: 65844
Gerrit-PatchSet: 86
Gerrit-Owner: Aarya <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Aarya <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Comment-Date: Thu, 26 Jan 2023 08:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment