[S] Change in flashrom[master]: flashrom.c: Add switch for legacy impl of erasure path

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Felix Singer, Thomas Heijligen, Aarya.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71119 )

Change subject: flashrom.c: Add switch for legacy impl of erasure path
......................................................................


Patch Set 13:

(2 comments)

Patchset:

PS10:
> `
> Ack

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/71119/comment/4b479c5d_340910ad 
PS12, Line 37: use_legacy_erase_path
> `use_legacy_erase_path` is not modified anywhere. […]
> You _could_ add it as a build flag however this is easy enough to toggle with a one-line commit too. I believe Thomas is catching up on email however he could perhaps help advise with working towards making the new algorithm the default.

My suggestion once you have your work landed on HEAD is to send a email to the mailing list/IRC channel and try to engage some folks to help with testing. The other part is to try and build up the portfolio of unit-test coverage around this new algorithm that instrument the fundamental data structures and procedures mapped over them at play here. Furthermore the unit-tests will help mature not just the functional code quality but also the code structure.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71119
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5660db0067c1c799dcb5c8e83b4a4826b236442
Gerrit-Change-Number: 71119
Gerrit-PatchSet: 13
Gerrit-Owner: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Aarya <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Felix Singer <[e-mail]>
Gerrit-Attention: Thomas Heijligen <[e-mail]>
Gerrit-Attention: Aarya <[e-mail]>
Gerrit-Comment-Date: Thu, 26 Jan 2023 07:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Comment-In-Reply-To: Aarya <[e-mail]>
Gerrit-MessageType: comment