Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33654
Change subject: spi25: Make internal functions static ......................................................................
spi25: Make internal functions static
These functions are only used in this file, so they can be made static.
Change-Id: I609971c79860e5697638714cf299ec4a4dcea038 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M spi25.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/33654/1
diff --git a/spi25.c b/spi25.c index fd87dc9..ba9eb0a 100644 --- a/spi25.c +++ b/spi25.c @@ -455,19 +455,19 @@ return result ? result : status; }
-int spi_chip_erase_60(struct flashctx *flash) +static int spi_chip_erase_60(struct flashctx *flash) { /* This usually takes 1-85s, so wait in 1s steps. */ return spi_simple_write_cmd(flash, 0x60, 1000 * 1000); }
-int spi_chip_erase_62(struct flashctx *flash) +static int spi_chip_erase_62(struct flashctx *flash) { /* This usually takes 2-5s, so wait in 100ms steps. */ return spi_simple_write_cmd(flash, 0x62, 100 * 1000); }
-int spi_chip_erase_c7(struct flashctx *flash) +static int spi_chip_erase_c7(struct flashctx *flash) { /* This usually takes 1-85s, so wait in 1s steps. */ return spi_simple_write_cmd(flash, 0xc7, 1000 * 1000);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33654 )
Change subject: spi25: Make internal functions static ......................................................................
Patch Set 1: Code-Review+2
Jacob Garber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/33654 )
Change subject: spi25: Make internal functions static ......................................................................
Abandoned
Reorganize into patch train