Change in ...flashrom[master]: ich_descriptors: Make internal functions static

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33653

Change subject: ich_descriptors: Make internal functions static
......................................................................

ich_descriptors: Make internal functions static

These functions are only used in this file, so they can be static.

Change-Id: I7c39e5d52a86de660cbb0bb7821c8ecea18075a2
Signed-off-by: Jacob Garber 
---
M ich_descriptors.c
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/33653/1

diff --git a/ich_descriptors.c b/ich_descriptors.c
index 0a4cf75..bfe92bb 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -442,7 +442,7 @@
    msg_pdbg2("\n");
 }

-void prettyprint_ich_descriptor_straps_ich8(const struct ich_descriptors *desc)
+static void prettyprint_ich_descriptor_straps_ich8(const struct ich_descriptors *desc)
 {
    static const char * const str_GPIO12[4] = {
    	"GPIO12",
@@ -504,7 +504,7 @@
    msg_pdbg2("\n");
 }

-void prettyprint_ich_descriptor_pchstraps45678_56(const struct ich_desc_south_strap *s)
+static void prettyprint_ich_descriptor_pchstraps45678_56(const struct ich_desc_south_strap *s)
 {
    /* PCHSTRP4 */
    msg_pdbg2("Intel PHY is %s.\n",
@@ -528,7 +528,7 @@
    /* PCHSTRP8 */
 }

-void prettyprint_ich_descriptor_pchstraps111213_56(const struct ich_desc_south_strap *s)
+static void prettyprint_ich_descriptor_pchstraps111213_56(const struct ich_desc_south_strap *s)
 {
    /* PCHSTRP11 */
    msg_pdbg2("SMLink1 GP Address is %sabled.\n",
@@ -544,7 +544,7 @@
    /* PCHSTRP13 */
 }

-void prettyprint_ich_descriptor_straps_ibex(const struct ich_desc_south_strap *s)
+static void prettyprint_ich_descriptor_straps_ibex(const struct ich_desc_south_strap *s)
 {
    static const uint8_t dec_t209min[4] = {
    	100,
@@ -642,7 +642,7 @@
    msg_pdbg2("\n");
 }

-void prettyprint_ich_descriptor_straps_cougar(const struct ich_desc_south_strap *s)
+static void prettyprint_ich_descriptor_straps_cougar(const struct ich_desc_south_strap *s)
 {
    msg_pdbg2("--- PCH ---\n");

@@ -811,7 +811,7 @@
    }
 }

-void prettyprint_rdid(uint32_t reg_val)
+static void prettyprint_rdid(uint32_t reg_val)
 {
    uint8_t mid = reg_val & 0xFF;
    uint16_t did = ((reg_val >> 16) & 0xFF) | (reg_val & 0xFF00);

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33653 )

Change subject: ich_descriptors: Make internal functions static
......................................................................

Patch Set 1: Code-Review+2

[Jacob Garber (Code Review)]

Jacob Garber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/33653 )

Change subject: ich_descriptors: Make internal functions static
......................................................................

Abandoned

Reorganize into patch train