Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33666
Change subject: flashrom: Make internal functions static ......................................................................
flashrom: Make internal functions static
These functions are only used in this file, so they can be made static.
Change-Id: I7b63464bb8b5a25fc004350a188dab6ee5c1a204 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M flashrom.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/33666/1
diff --git a/flashrom.c b/flashrom.c index b47d0a2..ea3d002 100644 --- a/flashrom.c +++ b/flashrom.c @@ -738,7 +738,7 @@ }
/* start is an offset to the base address of the flash chip */ -int check_erased_range(struct flashctx *flash, unsigned int start, +static int check_erased_range(struct flashctx *flash, unsigned int start, unsigned int len) { int ret; @@ -2055,7 +2055,7 @@ } }
-void print_sysinfo(void) +static void print_sysinfo(void) { #if IS_WINDOWS SYSTEM_INFO si; @@ -2235,7 +2235,7 @@ /* FIXME: This function signature needs to be improved once doit() has a better * function signature. */ -int chip_safety_check(const struct flashctx *flash, int force, int read_it, int write_it, int erase_it, +static int chip_safety_check(const struct flashctx *flash, int force, int read_it, int write_it, int erase_it, int verify_it) { const struct flashchip *chip = flash->chip;
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33666 )
Change subject: flashrom: Make internal functions static ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33666/1/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/33666/1/flashrom.c@742 PS1, Line 742: unsigned int len) Please maintain alignment, or remove line break if it fits in 112 chars.
https://review.coreboot.org/#/c/33666/1/flashrom.c@2239 PS1, Line 2239: int verify_it) Please maintain alignment. Would prefer the line break after `force,`.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33666
to look at the new patch set (#2).
Change subject: flashrom: Make internal functions static ......................................................................
flashrom: Make internal functions static
These functions are only used in this file, so they can be made static.
Change-Id: I7b63464bb8b5a25fc004350a188dab6ee5c1a204 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M flashrom.c 1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/33666/2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33666 )
Change subject: flashrom: Make internal functions static ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33666/1/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/33666/1/flashrom.c@742 PS1, Line 742: unsigned int len)
Please maintain alignment, or remove line break if it fits in 112 chars.
Done
https://review.coreboot.org/#/c/33666/1/flashrom.c@2239 PS1, Line 2239: int verify_it)
Please maintain alignment. Would prefer the line break after `force,`.
Done
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33666 )
Change subject: flashrom: Make internal functions static ......................................................................
Patch Set 2:
Hmmm, looking at what needs to be done I think it's better to abandon these current patches and reorganize them into a patch train (and combine the smaller ones together).
Jacob Garber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/33666 )
Change subject: flashrom: Make internal functions static ......................................................................
Abandoned
Reorganize into patch train
-
Jacob Garber (Code Review) -
Nico Huber (Code Review)