Attention is currently required from: Edward O'Callaghan, Daniel Campello, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59532 )
Change subject: [FIX ME] tests: Add test for extract operation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
I believe Peter is right and there is some issues due to the differences between the Chromium fork a […]
Peter, Daniel, thank you for information, very useful! Now I understand how this situation has happened.
And thanks for the link to another patch. Just to be precise, that patch is
"Make -r/-w/-v argument optional"
but here we have do_extract which is supposed to be -x (which is none of -r/-w/-v)?
Is it possible to re-write do_extract so that it is only doing what it needs to be doing: prepare_layout_for_extraction() and write_buf_to_include_args() without dealing with filenames?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13107c0e095d53184e32a41fa72227cf7dc1d449
Gerrit-Change-Number: 59532
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 01 Dec 2021 04:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Campello
campello@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment