Change in flashrom[master]: [FIX ME] tests: Add test for extract operation

[Daniel Campello (Code Review)]

Attention is currently required from: Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk, Peter Marheine.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59532 )

Change subject: [FIX ME] tests: Add test for extract operation
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS1:
> Peter, Daniel, thank you for information, very useful! Now I understand how this situation has happe […]
> I think all you need to do is to take the first change in flashrom.c from the referenced patch and that should solve the issue:

if (filename)
		ret = write_buf_to_file(buf, size, filename);

(see line 1103 in https://review.coreboot.org/c/flashrom/+/52362/19/flashrom.c )



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59532
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13107c0e095d53184e32a41fa72227cf7dc1d449
Gerrit-Change-Number: 59532
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Daniel Campello <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Daniel Campello <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Daniel Campello <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Comment-Date: Wed, 01 Dec 2021 04:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Campello <[e-mail]>
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Comment-In-Reply-To: Peter Marheine <[e-mail]>
Gerrit-MessageType: comment