Change in flashrom[master]: [RFC][WPTST] flashchips: enable write-protection for W25Q{64,128}.V

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59071 ) Change subject: [RFC][WPTST] flashchips: enable write-protection for W25Q{64,128}.V ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/59071/comment/bcbef773_dbce1c5a PS10, Line 7: enable write-protection for W25Q{64,128}.V
Yes, these are real chips. […] Good, if you tested real chips, could you please mention this in commit message?
I am not sure about every configuration of bits, let's check with Nikolai, since he has been testing lots of chips recently. -- To view, visit https://review.coreboot.org/c/flashrom/+/59071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iccb69a8d3a0dd2192e2c938caddaf07b1889ed35 Gerrit-Change-Number: 59071 Gerrit-PatchSet: 10 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 03:55:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-MessageType: comment
participants (1)
-
Anastasia Klimchuk (Code Review)