Change in flashrom[master]: meson.build: Sanitize the version string

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 )

Change subject: meson.build: Sanitize the version string
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/c/flashrom/+/35566/2/meson.build 
File meson.build:

https://review.coreboot.org/c/flashrom/+/35566/2/meson.build@360 
PS2, Line 360: #strip dirty version info
> Well it makes doing "development" against libflashrom more difficult. […]
> Unconditionally stripping a -dirty defeats the purpose of a -dirty.
> However, it seems futile to argue, if we have to drop 80% of the
> version information anyway.

If many people use pkgconfig during development, I wonder why nobody
fixes it? The original argument was to make the version "numbers"
comparable. But in-development versions are not comparable anyway.
It just makes no sense...

How about we make the dash-stripping a development option? Or even
set the version to 99.99 for anything in development? I'd like to
avoid that anyone accidentally builds something that looks like a
release but isn't.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/35566
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545
Gerrit-Change-Number: 35566
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Limonciello <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Jacob Garber <[e-mail]>
Gerrit-Reviewer: Mario Limonciello <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Richard Hughes <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Mon, 14 Oct 2019 17:15:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Limonciello <[e-mail]>
Comment-In-Reply-To: Nico Huber <[e-mail]>
Gerrit-MessageType: comment