View Change
1 comment:
File meson.build:
Patch Set #2, Line 360: #strip dirty version info
Well it makes doing "development" against libflashrom more difficult. […]
Unconditionally stripping a -dirty defeats the purpose of a -dirty.
However, it seems futile to argue, if we have to drop 80% of the
version information anyway.
If many people use pkgconfig during development, I wonder why nobody
fixes it? The original argument was to make the version "numbers"
comparable. But in-development versions are not comparable anyway.
It just makes no sense...
How about we make the dash-stripping a development option? Or even
set the version to 99.99 for anything in development? I'd like to
avoid that anyone accidentally builds something that looks like a
release but isn't.
To view, visit change 35566. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545
Gerrit-Change-Number: 35566
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Limonciello <superm1@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Mario Limonciello <superm1@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Richard Hughes <richard@hughsie.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 14 Oct 2019 17:15:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Limonciello <superm1@gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment