Change in flashrom[master]: meson.build: Sanitize the version string
Mario Limonciello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35566 ) Change subject: meson.build: Sanitize the version string ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/flashrom/+/35566/2/meson.build File meson.build: https://review.coreboot.org/c/flashrom/+/35566/2/meson.build@360 PS2, Line 360: #strip dirty version info
yes, I get that. but is there really a use case for dirty packages? […] Well it makes doing "development" against libflashrom more difficult. It would be better to lie about the version and keep the dirty stuff out so it can at least be linked against.
-- To view, visit https://review.coreboot.org/c/flashrom/+/35566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25587ed2ad7fbcffdf14eb758c1f0d6ab2aea545 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Limonciello <superm1@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca> Gerrit-Reviewer: Mario Limonciello <superm1@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Richard Hughes <richard@hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 14 Oct 2019 16:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mario Limonciello <superm1@gmail.com> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment
participants (1)
-
Mario Limonciello (Code Review)