Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices

[Hung-Te Lin (Code Review)]

Attention is currently required from: Nico Huber, Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 )

Change subject: linux_mtd: Switch fopen() to open() for MTD devices
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
> I think Nico's point about read() being able to return a shorter read is a good one and I'm thinking […]
> I'm fine abandoning this change, but I'm also not really convinced if fread is better.

It's true fread/fwrite have some internal retry loops so reading or writing to a real file should work properly. However for device files, I wonder if the retry would cause unexpected behavior in underlying driver / hardware. IMHO if we are accessing a driver via device file, any interrupt should be considered as failure, not silently retrying...

Having said that, if the fread/fwrite version is known to work and we don't see problems, I do agree there's no need to change to read/write.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/50206
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d
Gerrit-Change-Number: 50206
Gerrit-PatchSet: 2
Gerrit-Owner: Douglas Anderson <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Douglas Anderson <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Comment-Date: Mon, 15 Mar 2021 15:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Douglas Anderson <[e-mail]>
Gerrit-MessageType: comment