Attention is currently required from: Nico Huber, Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    I think Nico's point about read() being able to return a shorter read is a good one and I'm thinking […]

    I'm fine abandoning this change, but I'm also not really convinced if fread is better.

    It's true fread/fwrite have some internal retry loops so reading or writing to a real file should work properly. However for device files, I wonder if the retry would cause unexpected behavior in underlying driver / hardware. IMHO if we are accessing a driver via device file, any interrupt should be considered as failure, not silently retrying...

    Having said that, if the fread/fwrite version is known to work and we don't see problems, I do agree there's no need to change to read/write.

To view, visit change 50206. To unsubscribe, or for help writing mail filters, visit settings.