Change in flashrom[master]: linux_mtd: Switch fopen() to open() for MTD devices

[Hung-Te Lin (Code Review)]

Attention is currently required from: Nico Huber, Douglas Anderson, Edward O'Callaghan, Angel Pons, Patrick Rudolph.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50206 )

Change subject: linux_mtd: Switch fopen() to open() for MTD devices
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
> I'm fine abandoning this change, but I'm also not really convinced if fread is better. […]
> The comment said "Try to align reads to eraseblock size.".

So, if you use fread, the stdio may do unaligned reads internally. If we call read directly, at least we can look at return values, decide if we should go back to previous aligned offset and read again.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/50206
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb00b049ba5aa0bc8fdc591ac1f9861ad5d428d
Gerrit-Change-Number: 50206
Gerrit-PatchSet: 2
Gerrit-Owner: Douglas Anderson <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Douglas Anderson <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Comment-Date: Mon, 15 Mar 2021 16:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <[e-mail]>
Comment-In-Reply-To: Douglas Anderson <[e-mail]>
Gerrit-MessageType: comment