Nico Huber has posted comments on this change. ( https://review.coreboot.org/21934 )
Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c File nicintel_eeprom.c:
https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106 PS1, Line 106: return (device_id & 0xfff0) == 0x1530;
Are you sure about this? 0x157b and 0x157c seem valid in addition to 0x153x
As this was supposed to be a fixup!, I tried to anticipate what the author intended. And, as the comment suggests, this is not supposed to be future proof.
Anyway, `device_id >= 0x1530` should work as well (but doesn't align with current nicintel_spi.c).
-
Nico Huber (Code Review)