Nico Huber posted comments on this change.

View Change

Patch set 1:

(1 comment)

• File nicintel_eeprom.c:

  • Patch Set #1, Line 106: return (device_id & 0xfff0) == 0x1530;

    Are you sure about this? 0x157b and 0x157c seem valid in addition to 0x153x

    As this was supposed to be a fixup!, I tried to anticipate what
    the author intended. And, as the comment suggests, this is not
    supposed to be future proof.

    Anyway, `device_id >= 0x1530` should work as well (but doesn't
    align with current nicintel_spi.c).

To view, visit change 21934. To unsubscribe, visit settings.