Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: Thanks for starting the effort. Many people stumbled over the odd #if mess in this area, lately. While the generated .h file works somehow, I don't think it's necessary. `enum programmer` seems pretty much unused and could be removed instead?
Also, Thomas mentioned the thought to move the actual pro- grammer structs into the respective .c files. Then we'd only need a global array with pointers.
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/7bab6ad5_9fec7ad2 PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh) This should be run as a recipe for the file. Currently it would be re-written on every `make` run, right? I'm not sure how our depen- dency tracking copes with that.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/49599/comment/81bf9082_bb672d28 PS4, Line 43: #include "programmer_table.c" .c includes are generally discouraged.
-
Nico Huber (Code Review)