Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer.

View Change

3 comments:

• Patchset:

  • Patch Set #4:

    Thanks for starting the effort. Many people stumbled over the
    odd #if mess in this area, lately. While the generated .h file
    works somehow, I don't think it's necessary. `enum programmer`
    seems pretty much unused and could be removed instead?

    Also, Thomas mentioned the thought to move the actual pro-
    grammer structs into the respective .c files. Then we'd only
    need a global array with pointers.

• File Makefile:

  • Patch Set #4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)

    This should be run as a recipe for the file. Currently it would be
    re-written on every `make` run, right? I'm not sure how our depen-
    dency tracking copes with that.

• File flashrom.c:

  • Patch Set #4, Line 43: #include "programmer_table.c"

    .c includes are generally discouraged.

To view, visit change 49599. To unsubscribe, or for help writing mail filters, visit settings.