Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 )
Change subject: [RFC] writeprotect, cli_classic: delete old writeprotect code ......................................................................
Patch Set 6:
(6 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/58474/comment/bf21de41_47e64330 PS6, Line 700: complete until support is fully implemented?
https://review.coreboot.org/c/flashrom/+/58474/comment/4326cdaf_c751aa52 PS6, Line 702: write protect is not supported on this flash chip is it not supported on this flash chip, or not supported in flashrom?
https://review.coreboot.org/c/flashrom/+/58474/comment/3dc0edf0_22f71f17 PS6, Line 762: (void) wp_mode_opt; : (void) wp_region; sorry maybe that's a silly question, but what these two lines are doing?
File writeprotect.h:
https://review.coreboot.org/c/flashrom/+/58474/comment/97d66870_a90728c8 PS6, Line 24: WP_MODE_DISABLED, : WP_MODE_HARDWARE, : WP_MODE_POWER_CYCLE, : WP_MODE_PERMANENT, Is there a reason the comments on enum values have been removed?
File writeprotect.c:
PS3:
The only reason I was thinking to temporarily keep struct wp, is to keep cli_classic compiling. […]
This patch definitely becomes easier to review :)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58474/comment/7bc36102_d9d1face PS6, Line 18: #include <stdio.h> : #include <stdlib.h> : #include <string.h> : : #include "flash.h" : #include "chipdrivers.h" Technically, these includes are not needed (since the code has been removed)?