Attention is currently required from: Nico Huber, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58482 )
Change subject: [RFC] writeprotect: implement wp_{get,set}_range()
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
I guess a separate tool that handles only block protection (or write > protection or flash confi […]
+1 to getting the right abstraction from the beginning, libflashrom entry-points is certainly that was discussed before during the first draft of the patches. I think we can knock the signatures into good shape during review for a good API.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58482
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7d26f43fb05c5828b9839bb57a28fa1088dcd9a0
Gerrit-Change-Number: 58482
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 01:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment