Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

View Change

6 comments:

• File cli_classic.c:

  • Patch Set #6, Line 700: complete

    until support is fully implemented?

  • Patch Set #6, Line 702: write protect is not supported on this flash chip

    is it not supported on this flash chip, or not supported in flashrom?

  • Patch Set #6, Line 762:

    (void) wp_mode_opt;
    	(void) wp_region;
    

    sorry maybe that's a silly question, but what these two lines are doing?

• File writeprotect.h:

  • Patch Set #6, Line 24:

    	WP_MODE_DISABLED,
    	WP_MODE_HARDWARE,
    	WP_MODE_POWER_CYCLE,
    	WP_MODE_PERMANENT,
    

    Is there a reason the comments on enum values have been removed?

• File writeprotect.c:

  • Patch Set #3:

    > The only reason I was thinking to temporarily keep struct wp, is to keep cli_classic compiling. […]

    This patch definitely becomes easier to review :)

• File writeprotect.c:

  • Patch Set #6, Line 18:

    #include <stdio.h>
    #include <stdlib.h>
    #include <string.h>
    
    #include "flash.h"
    #include "chipdrivers.h"
    

    Technically, these includes are not needed (since the code has been removed)?

To view, visit change 58474. To unsubscribe, or for help writing mail filters, visit settings.