[flashrom-gerrit] Change in flashrom[master]: flashchips: Add Spansion S25FL512S

[Bernhard Urban-Forster (Code Review)]

Bernhard Urban-Forster has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38596 )

Change subject: flashchips: Add Spansion S25FL512S
......................................................................


Patch Set 7:

(5 comments)

What is missing to get this merged?

https://review.coreboot.org/c/flashrom/+/38596/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/38596/4//COMMIT_MSG@14 
PS4, Line 14: ```console
            : $ flashrom -p linux_spi:dev=/dev/spidev0.0,spispeed=512 -r content.bin
            : ```
> Just one line and indent with four spaces or tab?
> Ack

https://review.coreboot.org/c/flashrom/+/38596/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/38596/6//COMMIT_MSG@7 
PS6, Line 7: flashcips
> nice catch
> ha, thank you! :-)

https://review.coreboot.org/c/flashrom/+/38596/3/flashchips.c 
File flashchips.c:

https://review.coreboot.org/c/flashrom/+/38596/3/flashchips.c@15979 
PS3, Line 15979: FEATURE_4BA_EAR7
> I was able to get erase/writes working when using FEATURE_4BA_NATIVE
> Ack

https://review.coreboot.org/c/flashrom/+/38596/5/flashchips.c 
File flashchips.c:

https://review.coreboot.org/c/flashrom/+/38596/5/flashchips.c@15989 
PS5, Line 15989: 		},
> oops, sorry if my comment on github was confusing. Please re-add the bulk erase opcodes (60 and c7). […]
> Ah I see. I've added it back, and successfully re-ran my tests. Thank you!

https://review.coreboot.org/c/flashrom/+/38596/6/flashchips.c 
File flashchips.c:

https://review.coreboot.org/c/flashrom/+/38596/6/flashchips.c@15980 
PS6, Line 15980: TEST_OK_PREW
> Yep, and I verified them independently as well.
> Yes, I've tested read, erase and write.