- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Dmitry Zhadinets (Code Review) 22 Mar '25

22 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 5: (11 comments) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86875/comment/7d2e9291_05e28814?us… : PS4, Line 83: * > This documentation needs to explain about formatting Hmmmm. The user does not affect this, but as you wish. File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/9e3097ef_424d2a04?us… : PS2, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ : char *message; : va_list args_attempt; : va_copy(args_attempt, args); : int size = vsnprintf(NULL, 0, format, args_attempt); : va_end(args_attempt); : if (size < 0) : return size; : message = malloc(size+1); : if (!message) : return -ENOMEM; : vsnprintf(message, size + 1, format, args); : global_log_callback_v2(level, message, global_log_user_data); : free(message); : return 0; > Alright, I can agree on that. […] I hope I understood markers correctly File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/3048a4ba_74ce1643?us… : PS4, Line 56: flashrom_log_callback_v2_handler > This is a static function, so it doesn't have to start with "flashrom" , also I would try to give it […] Done https://review.coreboot.org/c/flashrom/+/86875/comment/e60ddde1_ee8e6916?us… : PS4, Line 57: > You probably don't need all these tabs, also I think this fits on one line? fn name and all params Done https://review.coreboot.org/c/flashrom/+/86875/comment/6be5d942_a8bfae88?us… : PS4, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ > You need to align with comments style (https://flashrom.org/dev_guide/development_guide. […] This is a question to a reviewer. I propose removing double allocation and maintaining messages at a constant length. How long can a single message generated by Flashrom be? A length of 1K might be excessive. File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/59a91b79_9ecbbe99?us… : PS4, Line 3: : * Copyright 2020 Google LLC > I commented on the other patch too, there should be your name here! Done https://review.coreboot.org/c/flashrom/+/86875/comment/e9c39f97_5714c31c?us… : PS4, Line 30: last_callback_version = 1; > We usually avoid global state (if possible), and in this case I think you can avoid it by returning […] Done https://review.coreboot.org/c/flashrom/+/86875/comment/6627a992_91e7cd05?us… : PS4, Line 48: logapi_test_success > Thank you so much for adding tests! […] Done https://review.coreboot.org/c/flashrom/+/86875/comment/afefb00f_f51d78f0?us… : PS4, Line 59: and > unfinished sentence? fixed https://review.coreboot.org/c/flashrom/+/86875/comment/fab052dd_344858d3?us… : PS4, Line 60: assert_int_equal(last_callback_version, 2); > You don't need the global state for v2 , you upgraded it, so it doesn't need global state! […] I re-implemented tests https://review.coreboot.org/c/flashrom/+/86875/comment/eb8f6956_063b5372?us… : PS4, Line 62: flashrom_set_log_callback(test_log_callback); : print(FLASHROM_MSG_INFO, "%s", "\n"); : /* check that v1 calback set back */ : assert_int_equal(last_callback_version, 1); > why do you reset the callback again (3rd time)? I don't think API clients would be setting callbacks […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 5 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Mar 2025 02:25:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Simon Arlott has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > To begin with, I love tests, and even more so, I love flashrom tests! (git history can confirm :)) […] I've added a test and found a bug writing the SPI mode. Unfortunately it hasn't fixed the need to use the echo command to wait for each command to complete, so it's still slower than it could be. -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 6 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Mar 2025 22:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Simon Arlott (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Simon Arlott has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 6 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Mar 2025 22:50:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for Logger Callback
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Dmitry Zhadinets, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86875?usp=email ) Change subject: libflashrom: Update the API for Logger Callback ...................................................................... Patch Set 4: (13 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/86875/comment/8dfa9491_dd7166d1?us… : PS2, Line 7: libflashrom: Update the API for Logger Callback > I agree that the new API should appear fully-formed, not with two different ABIs (that is, there sho […] Alright, it seems you both agree the patch can do more than one thing, then the title is fine. I will close this comment. File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86875/comment/b98e62cb_e7f3c5a8?us… : PS4, Line 83: * This documentation needs to explain about formatting File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/55caf66e_410ecafd?us… : PS2, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ : char *message; : va_list args_attempt; : va_copy(args_attempt, args); : int size = vsnprintf(NULL, 0, format, args_attempt); : va_end(args_attempt); : if (size < 0) : return size; : message = malloc(size+1); : if (!message) : return -ENOMEM; : vsnprintf(message, size + 1, format, args); : global_log_callback_v2(level, message, global_log_user_data); : free(message); : return 0; > I think it's better to do the formatting inside libflashrom, and just pass strings. […] Alright, I can agree on that. Also, v1 (initial version) works as before, no formatting (in case someone wants v1), is this correct? Then my comment to this code block is to add few new lines to separate logic pieces of code (63-64, 68-69, 71-72, 73-74) https://review.coreboot.org/c/flashrom/+/86875/comment/02d83038_bd6a775f?us… : PS2, Line 79: : global_log_callback = flashrom_log_callback_v2_handler; > I agree that the current approach (having only one callback stored, and expressing the old API in te […] Alright, I can understand. Also you both agree! I close this comment, but I have few comments to code style File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/f56b065b_7b5a5b82?us… : PS4, Line 56: flashrom_log_callback_v2_handler This is a static function, so it doesn't have to start with "flashrom" , also I would try to give it a name which explains what it is doing ("handler" can be anything) I would go with something painfully obvious like `format_message_and_invoke_log_callback_v2` but tell me if you have other ideas https://review.coreboot.org/c/flashrom/+/86875/comment/0afe4687_059c60e3?us… : PS4, Line 57: You probably don't need all these tabs, also I think this fits on one line? fn name and all params https://review.coreboot.org/c/flashrom/+/86875/comment/88960847_2a3e3286?us… : PS4, Line 59: /* Dynamic messages and double formatting may not be ideal, : as they are slow. It would be better to limit the message : size to a fixed value (e.g., char message[1024] = {0};). */ You need to align with comments style (https://flashrom.org/dev_guide/development_guide.html#coding-style) but tldr, add asterisk on each line File tests/libflashrom.c: https://review.coreboot.org/c/flashrom/+/86875/comment/f3b5f3bf_126fe309?us… : PS4, Line 3: : * Copyright 2020 Google LLC I commented on the other patch too, there should be your name here! https://review.coreboot.org/c/flashrom/+/86875/comment/e5cae834_6e112cb2?us… : PS4, Line 30: last_callback_version = 1; We usually avoid global state (if possible), and in this case I think you can avoid it by returning a value? (something special like 0x666 or anything non-zero should work). Then print should return it back and then you can assert it. As a good side-effect, this will also test a propagation of return values. https://review.coreboot.org/c/flashrom/+/86875/comment/f20912f8_2ee79770?us… : PS4, Line 48: logapi_test_success Thank you so much for adding tests! Usually, tests should be as granular as possible, and if possible, one test tests one thing. Concretely here, you need to split your test method into two, `flashrom_set_log_callback_test_success` and `flashrom_set_log_callback_v2_test_success` the names (ideally) represent the function being tested, so the easiest is to use the fn name in the test name. https://review.coreboot.org/c/flashrom/+/86875/comment/4c1d8f69_07f9cf2c?us… : PS4, Line 59: and unfinished sentence? https://review.coreboot.org/c/flashrom/+/86875/comment/a1181c9d_3181204e?us… : PS4, Line 60: assert_int_equal(last_callback_version, 2); You don't need the global state for v2 , you upgraded it, so it doesn't need global state! You can modify user_data inside the callback function, and then assert that it is expected value afterwards - that's what the real life usage will be https://review.coreboot.org/c/flashrom/+/86875/comment/6b58ced9_8673bca2?us… : PS4, Line 62: flashrom_set_log_callback(test_log_callback); : print(FLASHROM_MSG_INFO, "%s", "\n"); : /* check that v1 calback set back */ : assert_int_equal(last_callback_version, 1); why do you reset the callback again (3rd time)? I don't think API clients would be setting callbacks multiple times, and especially different versions? I would remove that last part, and split first two parts into two separate tests functions (in the same file, in this file) -- To view, visit https://review.coreboot.org/c/flashrom/+/86875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea738bd371fa3d69b9cf222c89ee67490d30af39 Gerrit-Change-Number: 86875 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Mar 2025 13:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Zhadinets <dzhadinets(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Update supported flashchips page because we split the large file
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86953?usp=email ) Change subject: doc: Update supported flashchips page because we split the large file ...................................................................... doc: Update supported flashchips page because we split the large file Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/supported_hw/supported_flashchips.rst 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/86953/1 diff --git a/doc/supported_hw/supported_flashchips.rst b/doc/supported_hw/supported_flashchips.rst index 8e881d2..bd5be67 100644 --- a/doc/supported_hw/supported_flashchips.rst +++ b/doc/supported_hw/supported_flashchips.rst @@ -2,10 +2,10 @@ Supported flash chips ===================== -The list of all supported flash chips is in ``flashchips.c`` file in the source tree. -If you have a flashrom repo cloned locally, you can look at the file in your repo. +The info about all supported flash chips is in ``/flashchips`` directory in the source tree. +If you have a flashrom repo cloned locally, you can look at this directory in your repo. -Alternatively inspect the file on the `web UI of our GitHub mirror <https://github.com/flashrom/flashrom/blob/main/flashchips.c>`_. +Alternatively inspect it on the `web UI of our GitHub mirror <https://github.com/flashrom/flashrom/tree/main/flashchips>`_. If you can run flashrom locally, the command ``flashrom -L`` prints the list of all supported flash chips (see :doc:`/classic_cli_manpage` for more details on command line options). The output of this command is long, so you might -- To view, visit https://review.coreboot.org/c/flashrom/+/86953?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic6179517d0f951a32c0c4e0baf32677398224542 Gerrit-Change-Number: 86953 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Macronix MX77U25650FZ4I42
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Dolan Liu, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Dolan Liu. ( https://review.coreboot.org/c/flashrom/+/86348?usp=email ) Change subject: flashchips: Add Macronix MX77U25650FZ4I42 ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: > Hi Anastasia, […] I am resolving this, thanks to Daniel for review. Commit Message: https://review.coreboot.org/c/flashrom/+/86348/comment/d0469c6b_d9bc6a2b?us… : PS2, Line 12: TEST=sudo emerge flashrom and futility bios image via servo Could you please add one more line just listing the operations you tested (presumably read/write/erase). This line is mentioning internal tools that most of people don't know about. Keep this line, just add one more line to list the operations tested. thank you! File flashchips/macronix.c: https://review.coreboot.org/c/flashrom/+/86348/comment/66343ab4_ae12d8e2?us… : PS2, Line 2880: There are 3 extra tabs here, can you please remove them? you need the opening bracket to alight with the others -- To view, visit https://review.coreboot.org/c/flashrom/+/86348?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7866b2db343f4eb2bc194400ceca099d3af3b87d Gerrit-Change-Number: 86348 Gerrit-PatchSet: 2 Gerrit-Owner: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 07:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Iterator like API to get list of programmers
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86947?usp=email ) Change subject: libflashrom: Iterator like API to get list of programmers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is the alternative to CB:86921, right? So only one of these will be needed? -- To view, visit https://review.coreboot.org/c/flashrom/+/86947?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I89cce7625e8731ee26331934f36cfd1c8c570225 Gerrit-Change-Number: 86947 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 07:28:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Added API for capabilitible chips
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86946?usp=email ) Change subject: libflashrom: Added API for capabilitible chips ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: I started adding comments, but now I am thinking about the patch overall: is this the idea which was #3 in your thread on the mailing list? The idea that libflashrom probing should work in the same way as cli? As you know, I also want to have the same probing logic for libflashrom and cli. But I was thinking to have it as an actual v2 probing API. If we add a v2 probing which behaves like cli, will it solve your use case, so that you won't need this patch anymore? File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86946/comment/989be7b2_ad970ee6?us… : PS1, Line 230: fo for (typo) https://review.coreboot.org/c/flashrom/+/86946/comment/67762844_afd8c1de?us… : PS1, Line 231: * @param[in] flashprog The flash programmer used to access the chip. We usually add a line between brief and the rest, also a line between param and return File libflashrom.map: https://review.coreboot.org/c/flashrom/+/86946/comment/d03504db_416557a7?us… : PS1, Line 34: flashrom_supported_programmers This needs to be in the previous commit CB:86921 File tests/tests.c: https://review.coreboot.org/c/flashrom/+/86946/comment/ea60ba36_3ef56d27?us… : PS1, Line 456: const struct CMUnitTest libflashrom_tests[] = { : cmocka_unit_test(enumerators_test_success), : }; : ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL); What is the reason you are moving these lines? If this is accidental, please return then back :) -- To view, visit https://review.coreboot.org/c/flashrom/+/86946?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13c951f9404ae8b042cdb572e6117a09ac231747 Gerrit-Change-Number: 86946 Gerrit-PatchSet: 1 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 07:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... Patch Set 2: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86921/comment/ce13d6ee_d78160d6?us… : PS2, Line 169: flashrom_supported_programmers This needs to be added to libflashrom.map in this commit (it is currently in the next one) -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 06:51:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Added API to enumerate supported programmers
by Anastasia Klimchuk (Code Review) 21 Mar '25

21 Mar '25

Attention is currently required from: Dmitry Zhadinets. Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email ) Change subject: libflashrom: Added API to enumerate supported programmers ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/86921/comment/a97a578e_cd1c7117?us… : PS2, Line 6: : libflashrom: Added API to enumerate supported programmers Few corrections: `libflashrom: Add API to return the list of supported programmers` `Add` instead of Added because the typical rule is "write a commit title as if you giving a command to the source control" And also to be more exact: API returns the list -- To view, visit https://review.coreboot.org/c/flashrom/+/86921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib5275b742b849183b1fe701900040fee369a1d78 Gerrit-Change-Number: 86921 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dmitry Zhadinets <dzhadinets(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 06:39:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit